[GitHub] [velocity-tools] odoral commented on pull request #12: VELTOOLS-198

2022-11-08 Thread GitBox
odoral commented on PR #12: URL: https://github.com/apache/velocity-tools/pull/12#issuecomment-1307865377 > Now I wonder whether a TL would really be better than living without the cache. How big is the impact not using a cache? To be honest, we found this issue in a migration from

[GitHub] [velocity-tools] michael-o commented on pull request #12: VELTOOLS-198

2022-11-08 Thread GitBox
michael-o commented on PR #12: URL: https://github.com/apache/velocity-tools/pull/12#issuecomment-1307824138 @arkanovicz While Commons Pool is very nice I use if for heavy objects as well, how do you want to expose its configuration, lifecycle, etc. to the client? As of now, the tools are

[GitHub] [velocity-tools] arkanovicz commented on pull request #12: VELTOOLS-198

2022-11-08 Thread GitBox
arkanovicz commented on PR #12: URL: https://github.com/apache/velocity-tools/pull/12#issuecomment-1307816850 Thanks for identifying this issue. On [this page](https://stackoverflow.com/questions/4387170/decimalformat-formatdouble-in-different-threads) someone had a measurement of

[GitHub] [velocity-tools] michael-o commented on pull request #12: VELTOOLS-198

2022-11-08 Thread GitBox
michael-o commented on PR #12: URL: https://github.com/apache/velocity-tools/pull/12#issuecomment-1307742274 Now I wonder whether a TL would really be better than living without the cache. How big is the impact not using a cache? -- This is an automated message from the Apache Git

[jira] [Commented] (VELTOOLS-198) org.apache.velocity.tools.ConversionUtils#getNumberFormat(java.lang.String, java.util.Locale) is not thread safe for custom formats

2022-11-08 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/VELTOOLS-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630583#comment-17630583 ] Michael Osipov commented on VELTOOLS-198: - So basically we are talking about

[jira] [Commented] (VELTOOLS-198) org.apache.velocity.tools.ConversionUtils#getNumberFormat(java.lang.String, java.util.Locale) is not thread safe for custom formats

2022-11-08 Thread Oscar Doral (Jira)
[ https://issues.apache.org/jira/browse/VELTOOLS-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17630582#comment-17630582 ] Oscar Doral commented on VELTOOLS-198: -- I've created a pull request with a solution to move from

[jira] [Updated] (VELTOOLS-198) org.apache.velocity.tools.ConversionUtils#getNumberFormat(java.lang.String, java.util.Locale) is not thread safe for custom formats

2022-11-08 Thread Oscar Doral (Jira)
[ https://issues.apache.org/jira/browse/VELTOOLS-198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oscar Doral updated VELTOOLS-198: - Labels: pull-request-available (was: ) >

[jira] [Created] (VELTOOLS-198) org.apache.velocity.tools.ConversionUtils#getNumberFormat(java.lang.String, java.util.Locale) is not thread safe for custom formats

2022-11-08 Thread Oscar Doral (Jira)
Oscar Doral created VELTOOLS-198: Summary: org.apache.velocity.tools.ConversionUtils#getNumberFormat(java.lang.String, java.util.Locale) is not thread safe for custom formats Key: VELTOOLS-198 URL: