jtotht commented on PR #45:
URL: https://github.com/apache/velocity-engine/pull/45#issuecomment-2054064661
Actually, I could only test it with regular classes because of the project’s
Java 1.8 support. So other methods work definitely, records work hopefully. :)
--
This is an automated
michael-o commented on PR #45:
URL: https://github.com/apache/velocity-engine/pull/45#issuecomment-2054058792
Stupid question: is this limited to records only or will it work with any
method without get prefix?
--
This is an automated message from the Apache Git Service.
To respond to
jtotht opened a new pull request, #45:
URL: https://github.com/apache/velocity-engine/pull/45
Java 16 records (JEP 395) are a perfect fit for Velocity variables: they are
lightweight and desgined to contain immutable data. However, records don’t
follow the JavaBean convention: the getter
asfgit merged PR #43:
URL: https://github.com/apache/velocity-engine/pull/43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
arkanovicz commented on PR #43:
URL: https://github.com/apache/velocity-engine/pull/43#issuecomment-1999787845
> I have no further objections. @arkanovicz, what is your opinion?
Less code for us, and the custom parser test is functional, so no objection,
thanks for the upstream work
slachiewicz commented on code in PR #43:
URL: https://github.com/apache/velocity-engine/pull/43#discussion_r1524026355
##
velocity-engine-core/pom.xml:
##
@@ -139,29 +138,6 @@
-
-
-
slachiewicz commented on code in PR #43:
URL: https://github.com/apache/velocity-engine/pull/43#discussion_r1524025967
##
velocity-engine-core/pom.xml:
##
@@ -108,7 +108,7 @@
org.codehaus.mojo
javacc-maven-plugin
-
slachiewicz commented on code in PR #43:
URL: https://github.com/apache/velocity-engine/pull/43#discussion_r1517540877
##
velocity-custom-parser-example/pom.xml:
##
@@ -209,34 +209,6 @@
-
-
-
slachiewicz commented on code in PR #43:
URL: https://github.com/apache/velocity-engine/pull/43#discussion_r1517540295
##
velocity-engine-core/src/main/java/org/apache/velocity/runtime/parser/node/ParserTreeConstants.java:
##
@@ -1,24 +0,0 @@
-package
slachiewicz commented on code in PR #43:
URL: https://github.com/apache/velocity-engine/pull/43#discussion_r1517540054
##
velocity-engine-core/src/main/java/org/apache/velocity/runtime/parser/node/ParserVisitor.java:
##
@@ -1,332 +0,0 @@
-package
michael-o commented on code in PR #43:
URL: https://github.com/apache/velocity-engine/pull/43#discussion_r1517530848
##
velocity-custom-parser-example/pom.xml:
##
@@ -140,7 +140,7 @@
org.codehaus.mojo
javacc-maven-plugin
-
asfgit closed pull request #44: Change boxed primitive constructor calls to
more modern equivalents.
URL: https://github.com/apache/velocity-engine/pull/44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
asfgit merged PR #17:
URL: https://github.com/apache/velocity-tools/pull/17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
asfgit closed pull request #17: [VELTOOLS-207] Upgrade to EasyMock 5.2.0
URL: https://github.com/apache/velocity-tools/pull/17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
asfgit merged PR #18:
URL: https://github.com/apache/velocity-tools/pull/18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
eamonnmcmanus opened a new pull request, #44:
URL: https://github.com/apache/velocity-engine/pull/44
These constructors are [deprecated for
removal](https://bugs.openjdk.org/browse/JDK-8254324).
--
This is an automated message from the Apache Git Service.
To respond to the message,
asfgit closed pull request #42: [VELOCITY-976] Remove obsolete
VelTools66TestCase
URL: https://github.com/apache/velocity-engine/pull/42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
slachiewicz opened a new pull request, #43:
URL: https://github.com/apache/velocity-engine/pull/43
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
michael-o commented on PR #42:
URL: https://github.com/apache/velocity-engine/pull/42#issuecomment-1949240774
@arkanovicz Any objections?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
michael-o opened a new pull request, #18:
URL: https://github.com/apache/velocity-tools/pull/18
There is no reason to duplicate information from the POM and force devs to
keep the information in sync.
--
This is an automated message from the Apache Git Service.
To respond to the message,
michael-o opened a new pull request, #17:
URL: https://github.com/apache/velocity-tools/pull/17
This fixes test failures on newer Java versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
asfgit closed pull request #36: update the resource.loader configuration key to
resource.loaders when not used as a prefix
URL: https://github.com/apache/velocity-engine/pull/36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dependabot[bot] commented on PR #38:
URL: https://github.com/apache/velocity-engine/pull/38#issuecomment-1937082424
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor
asfgit closed pull request #38: Bump org.springframework:spring-core from
5.3.27 to 6.0.15 in /spring-velocity-support
URL: https://github.com/apache/velocity-engine/pull/38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
asfgit merged PR #41:
URL: https://github.com/apache/velocity-engine/pull/41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
asfgit merged PR #40:
URL: https://github.com/apache/velocity-engine/pull/40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
asfgit merged PR #39:
URL: https://github.com/apache/velocity-engine/pull/39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
michael-o opened a new pull request, #41:
URL: https://github.com/apache/velocity-engine/pull/41
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
michael-o commented on PR #37:
URL: https://github.com/apache/velocity-engine/pull/37#issuecomment-1925446221
Superseded by #40.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
michael-o opened a new pull request, #40:
URL: https://github.com/apache/velocity-engine/pull/40
Needs #39 first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
michael-o closed pull request #37: VELOCITY-970: velocity-engine-core contains
commons-io Maven descriptor
URL: https://github.com/apache/velocity-engine/pull/37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
michael-o opened a new pull request, #39:
URL: https://github.com/apache/velocity-engine/pull/39
Can be merged as soon as parent 6 is on Maven Central.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
michael-o commented on PR #37:
URL: https://github.com/apache/velocity-engine/pull/37#issuecomment-1925425736
Closing this because the Commons IO dependency will be removed after #39 has
been merged. Thank you for your effort.
--
This is an automated message from the Apache Git Service.
dependabot[bot] opened a new pull request, #38:
URL: https://github.com/apache/velocity-engine/pull/38
Bumps
[org.springframework:spring-core](https://github.com/spring-projects/spring-framework)
from 5.3.27 to 6.0.15.
Release notes
Sourced from
asfgit merged PR #1:
URL: https://github.com/apache/velocity-master/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
michael-o opened a new pull request, #1:
URL: https://github.com/apache/velocity-master/pull/1
Explicitly require Maven 3.2.5+ to build and Java 8 as runtime
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
tmortagne commented on PR #37:
URL: https://github.com/apache/velocity-engine/pull/37#issuecomment-1887573776
OK, this time I saw it I think :)
I'm not 100% sure my modification of maven-bundle-plugin is right, as I'm
not used to it.
--
This is an automated message from the Apache
tmortagne commented on PR #37:
URL: https://github.com/apache/velocity-engine/pull/37#issuecomment-1887307090
Hi @michael-o, thanks for taking a look.
I'm sorry, I don't see what you mean. The only reference left to commons-io
is [the
tmortagne opened a new pull request, #37:
URL: https://github.com/apache/velocity-engine/pull/37
Jira issue: https://issues.apache.org/jira/browse/VELOCITY-970
The idea is to remove commons-io from the velocity-engine-core JAR since
there does not seem to be a clear reason to do that
michael-o commented on PR #15:
URL: https://github.com/apache/velocity-tools/pull/15#issuecomment-1883045291
> I can't believe that this has been turned down. this is not the problem of
one committer but of everyone who wants to keep his software up-to-date.
Currently, velocity-tools is
ghueller commented on PR #15:
URL: https://github.com/apache/velocity-tools/pull/15#issuecomment-1883038445
I can't believe that this has been turned down. this is not the problem of
one committer but of everyone who wants to keep his software up-to-date.
Currently, velocity-tools is
arkanovicz merged PR #16:
URL: https://github.com/apache/velocity-tools/pull/16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
arkanovicz commented on PR #16:
URL: https://github.com/apache/velocity-tools/pull/16#issuecomment-1755981125
Thanks for the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
andygoblins opened a new pull request, #16:
URL: https://github.com/apache/velocity-tools/pull/16
I was trying to migrate to 3.x and noticed that VelocityLayoutServlet wasn't
working at all because it overwrote the deprecated version of mergeTemplate,
which is no longer called by
rproserpio opened a new pull request, #36:
URL: https://github.com/apache/velocity-engine/pull/36
Since 2.1 the configuration key `resource.loader` has been deprecated in
favor of `resource.loaders`.
This PR fixes a deprecation warning caused by the `spring-velocity-support`
module,
michael-o commented on PR #15:
URL: https://github.com/apache/velocity-tools/pull/15#issuecomment-1633095679
I can easily explain why I have immediate closed this out: Before opening a
PR for such a high-impact change I would expect a discussion in the JIRA issue
about a possible solution
ppodgorsek commented on PR #15:
URL: https://github.com/apache/velocity-tools/pull/15#issuecomment-1632979410
@michael-o Can you explain why modernising Velocity to use Jakarta is a joke
for you? It's not right to expect all downstream projects to use the Tomcat
migration tool when this
ChristopherSchultz commented on PR #15:
URL: https://github.com/apache/velocity-tools/pull/15#issuecomment-1632889781
I think it's totally serious. IMO, VelocityTools needs a branch (or main) to
migrate to Jakarta EE. Not everybody is going to let their web applications
languish forever.
michael-o commented on PR #15:
URL: https://github.com/apache/velocity-tools/pull/15#issuecomment-1632855512
This can't be serious
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
michael-o closed pull request #15: VELOCITY-942 - VelocityViewServlet extending
from jakarta.servlet instead of javax.servlet
URL: https://github.com/apache/velocity-tools/pull/15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
ppodgorsek opened a new pull request, #15:
URL: https://github.com/apache/velocity-tools/pull/15
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
ajaysharma2 commented on PR #14:
URL: https://github.com/apache/velocity-tools/pull/14#issuecomment-1601276429
Wrong target branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
michael-o closed pull request #14: Issue/confsrvdev 23885 fixing xss
URL: https://github.com/apache/velocity-tools/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
michael-o commented on PR #14:
URL: https://github.com/apache/velocity-tools/pull/14#issuecomment-1601213318
Looks like spam.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ajaysharma2 opened a new pull request, #14:
URL: https://github.com/apache/velocity-tools/pull/14
confsrvdev 23885 Fixed xss
changing java 5 to java8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
xiaoma20082008 commented on PR #25:
URL: https://github.com/apache/velocity-engine/pull/25#issuecomment-1552319618
I was fired after i started on this issues, and lost many commits on my old
computer as it's belong to the company, I'll restart now.
--
This is an automated message from
arkanovicz merged PR #35:
URL: https://github.com/apache/velocity-engine/pull/35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dependabot[bot] opened a new pull request, #35:
URL: https://github.com/apache/velocity-engine/pull/35
Bumps [spring-core](https://github.com/spring-projects/spring-framework)
from 5.3.26 to 5.3.27.
Release notes
Sourced from
arkanovicz closed pull request #17: Provide a flag to ignore exception when
template generator encounters…
URL: https://github.com/apache/velocity-engine/pull/17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
arkanovicz closed pull request #3: Added the S3Resource Loader to pull velocity
templates from Amazon S3…
URL: https://github.com/apache/velocity-engine/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
arkanovicz commented on PR #3:
URL: https://github.com/apache/velocity-engine/pull/3#issuecomment-1484027944
Ok, let's close it right away, then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
arkanovicz commented on PR #17:
URL: https://github.com/apache/velocity-engine/pull/17#issuecomment-1484026250
>> InvalidReferenceHandler
> That would mean a broader check including invalid method names etc,
And? I maintain that it's a typical use case for the
arkanovicz commented on PR #26:
URL: https://github.com/apache/velocity-engine/pull/26#issuecomment-1484022777
The PR has been merged to the 1.7.x branch. But I don't have neither the
time or the envy to release a 1.7.x version, so you'll have to use the SNAPSHOT
or join the Apache
arkanovicz merged PR #26:
URL: https://github.com/apache/velocity-engine/pull/26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
arkanovicz closed pull request #21: [Backport] Velocity 931 update secure
classlist
URL: https://github.com/apache/velocity-engine/pull/21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
arkanovicz commented on PR #21:
URL: https://github.com/apache/velocity-engine/pull/21#issuecomment-1484022148
Closing this PR, as it has been updated elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
arkanovicz commented on PR #3:
URL: https://github.com/apache/velocity-engine/pull/3#issuecomment-1484021923
The `isSourceModified()` always returns false. So even as a contribution, it
looks rather incomplete. Let's leave it here for now...
--
This is an automated message from the
arkanovicz merged PR #34:
URL: https://github.com/apache/velocity-engine/pull/34
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dependabot[bot] opened a new pull request, #34:
URL: https://github.com/apache/velocity-engine/pull/34
Bumps [spring-core](https://github.com/spring-projects/spring-framework)
from 5.3.20 to 5.3.26.
Release notes
Sourced from
69 matches
Mail list logo
