Re: [VOTE] Engine 2.0 RC5 Release quality

2017-01-25 Thread Claude Brisson
I totally agree. I left things as I found them basically because I had enough other things to learn about Maven by the time. If you want to help further on this one you are welcome. I will have a look, especially at the patching of the generated source code. I assume that this is absolutely

Re: [VOTE] Engine 2.0 RC5 Release quality

2017-01-25 Thread Claude Brisson
Changing my vote to [X] Leave at test build after Michael remarks (sigh...). On 16/01/2017 15:04, Claude Brisson wrote: And my vote: [ ] Leave at test build [ ] Alpha [ ] Beta [X] General Availability (GA) Claude

Re: [VOTE] Engine 2.0 RC5 Release quality

2017-01-16 Thread Michael Osipov
Am 2017-01-16 um 22:56 schrieb Claude Brisson: That was fast. On 16/01/2017 22:29, Michael Osipov wrote: Here are my comments referred in my the previous mail: * POM: use of JavaCC Maven Plugin: never ever add auto-generated code to src/, it completely breaks the agreed convention. Have

Re: [VOTE] Engine 2.0 RC5 Release quality

2017-01-16 Thread Claude Brisson
That was fast. On 16/01/2017 22:29, Michael Osipov wrote: Here are my comments referred in my the previous mail: * README.txt requires a rewrite, it still talks about Ant, old directory structures, and much more Ok. * POM: use of JavaCC Maven Plugin: never ever add auto-generated code

Re: [VOTE] Engine 2.0 RC5 Release quality

2017-01-16 Thread Michael Osipov
Am 2017-01-16 um 15:02 schrieb Claude Brisson: The Velocity Engine 2.0 RC5 is available. Main changes since the RC4: * the default encoding is now UTF-8 (and not the platform default) * commons-collections is not any more a compilation dependency * commons-lang3 dependency is not any more

Re: [VOTE] Engine 2.0 RC5 Release quality

2017-01-16 Thread Michael Osipov
Am 2017-01-16 um 15:02 schrieb Claude Brisson: The Velocity Engine 2.0 RC5 is available. Main changes since the RC4: * the default encoding is now UTF-8 (and not the platform default) * commons-collections is not any more a compilation dependency * commons-lang3 dependency is not any more

Re: [VOTE] Engine 2.0 RC5 Release quality

2017-01-16 Thread Greg Huber
[ ] Leave at test build [ ] Alpha [ ] Beta [x] General Availability (GA) +1 works great for me. Thanks. On 16 January 2017 at 14:02, Claude Brisson wrote: > The Velocity Engine 2.0 RC5 is available. > > Main changes since the RC4: > > * the default encoding is now UTF-8

Re: [VOTE] Engine 2.0 RC5 Release quality

2017-01-16 Thread Claude Brisson
And my vote: [ ] Leave at test build [ ] Alpha [ ] Beta [X] General Availability (GA) Claude - To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org For additional commands, e-mail: dev-h...@velocity.apache.org