Re: svn commit: r1769055 - in /velocity/tools/trunk: velocity-tools-generic/ velocity-tools-generic/src/main/java/org/apache/velocity/tools/generic/ velocity-tools-generic/src/test/java/org/apache/vel

2016-11-10 Thread Claude Brisson
When you restart a J2EE container, it will try to serialize the sessions on disk to restore them when reloading. This can only works if everything in the session is serializable, including the session toolbox itself. Since the RenderTool keeps references on a VelocityEngine, it cannot be

Re: Logging configuration

2016-11-10 Thread Claude Brisson
Any module anywhere can get a logger using one of the two static methods: Logger org.slf4j.LoggerFactory.getLogger(String loggerName) Logger org.slf4j.LoggerFactory.getLogger(Class targetClass) Calling one or the other is a matter of taste. It does not *have* to be the same logger anywhere in

Re: svn commit: r1769055 - in /velocity/tools/trunk: velocity-tools-generic/ velocity-tools-generic/src/main/java/org/apache/velocity/tools/generic/ velocity-tools-generic/src/test/java/org/apache/vel

2016-11-10 Thread Nathan Bubna
On Thu, Nov 10, 2016 at 4:19 AM, Sergiu Dumitriu wrote: > On 11/10/2016 03:01 AM, cbris...@apache.org wrote: > > Author: cbrisson > > Date: Thu Nov 10 08:01:41 2016 > > New Revision: 1769055 > > > > URL: http://svn.apache.org/viewvc?rev=1769055=rev > > Log: > > [tools]

Re: svn commit: r1769055 - in /velocity/tools/trunk: velocity-tools-generic/ velocity-tools-generic/src/main/java/org/apache/velocity/tools/generic/ velocity-tools-generic/src/test/java/org/apache/vel

2016-11-10 Thread Sergiu Dumitriu
On 11/10/2016 03:01 AM, cbris...@apache.org wrote: > Author: cbrisson > Date: Thu Nov 10 08:01:41 2016 > New Revision: 1769055 > > URL: http://svn.apache.org/viewvc?rev=1769055=rev > Log: > [tools] a tool should either be Serializable or forbid Session scope > > Modified: >

Logging configuration

2016-11-10 Thread Greg Huber
The name needs to be exactly Velocity which is not what I had expected, usually its the package name format ie org.apache.velocity. the docs suggest its org.apache.velocity.app.Velocity This seems to be set in RuntimeInstance: private Logger log =

Re: Logging configuration

2016-11-10 Thread Mike Kienenberger
+1 to using several appropriate functional names if we are picking loggers by String rather than by Class. On Thu, Nov 10, 2016 at 11:11 AM, Claude Brisson wrote: > On 10/11/2016 15:56, Greg Huber wrote: > >> Yes it does when I use name="Velocity" >> >> But as you are using

Re: svn commit: r1769055 - in /velocity/tools/trunk: velocity-tools-generic/ velocity-tools-generic/src/main/java/org/apache/velocity/tools/generic/ velocity-tools-generic/src/test/java/org/apache/vel

2016-11-10 Thread Sergiu Dumitriu
Yep, thanks for clarifying. I was just puzzled because almost all of the others had @ValidScope(Scope.Application). I guess this one can be used both in Request and Application scopes, so it was easier to just exclude the third one than to include these two. On 11/10/2016 08:58 AM, Claude Brisson

Re: Logging configuration

2016-11-10 Thread Greg Huber
Yes it does when I use name="Velocity" But as you are using the runtime instance logger its either on or off for the whole package. Using a per class I think enables more filtering as you can name="org.apache.velocity.app" level="DEBUG" purely for this package and name="org.apache.velocity"

Re: [ANNOUNCE] Velocity Engine 2.0 test build available

2016-11-10 Thread Greg Huber
Claude, I have tested the fix and it now works, thanks. ## One thing now is I cannot get the log into debug mode. I use commons-logging with log4j and the log4j-slf4j-impl as a bridge. Other jars that use slf4j will log to debug ok. The notes mention runtime.log.instance= maybe I