Re: Commens on VELTOOLS from trunk [1]

2018-06-25 Thread Claude Brisson
On 06/25/2018 06:59 PM, Michael Osipov wrote: Folks, release 3.0 is pending, I took some time to check the current project status. Here are my observations: * STATUS seems obsolete * WHY_THREE_JARS.txt seems obsolete * README.txt seems obsolete * ./test: this should be in src/test/resources

Commens on VELTOOLS from trunk [1]

2018-06-25 Thread Michael Osipov
Folks, release 3.0 is pending, I took some time to check the current project status. Here are my observations: * STATUS seems obsolete * WHY_THREE_JARS.txt seems obsolete * README.txt seems obsolete * ./test: this should be in src/test/resources somewhere * there are a lot of empty dirs: still

[jira] [Commented] (VELTOOLS-150) VelocityLayoutServlet allows clients to specify "layout" without performing any security checks.

2018-06-25 Thread Claude Brisson (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522904#comment-16522904 ] Claude Brisson commented on VELTOOLS-150: - I totally agree. At first I commited something very

[jira] [Resolved] (VELTOOLS-168) LinkTool doesn't handle appending params properly

2018-06-25 Thread Claude Brisson (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Brisson resolved VELTOOLS-168. - Resolution: Fixed Assignee: Claude Brisson Fix Version/s: 3.0

[jira] [Resolved] (VELTOOLS-160) XmlTool: possibility to add NamespaceContext for XPath (find method)

2018-06-25 Thread Claude Brisson (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Brisson resolved VELTOOLS-160. - Resolution: Fixed Assignee: Claude Brisson Fix Version/s: 3.0 XmlTool

[jira] [Resolved] (VELTOOLS-158) org.apache.velocity.tools.view.servlet.VelocityViewServlet line 55 super.getClass().getName()

2018-06-25 Thread Claude Brisson (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Brisson resolved VELTOOLS-158. - Resolution: Fixed Assignee: Claude Brisson Fix Version/s: 3.0 The

[jira] [Closed] (VELTOOLS-158) org.apache.velocity.tools.view.servlet.VelocityViewServlet line 55 super.getClass().getName()

2018-06-25 Thread Claude Brisson (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Brisson closed VELTOOLS-158. --- > org.apache.velocity.tools.view.servlet.VelocityViewServlet line 55 >

Re: Cannot build Tools from trunk

2018-06-25 Thread Claude Brisson
It's running for me under java 8. Log for the cargo section copy pasted below. Is it a linux/windows cargo/jetty problem? [INFO] --- cargo-maven2-plugin:1.6.8:start (start-server) @ velocity-tools-examples-showcase --- [INFO] [2.ContainerStartMojo] Resolved container artifact

[jira] [Resolved] (VELTOOLS-150) VelocityLayoutServlet allows clients to specify "layout" without performing any security checks.

2018-06-25 Thread Claude Brisson (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Brisson resolved VELTOOLS-150. - Resolution: Fixed Assignee: Claude Brisson Fix Version/s: 3.0 The

[jira] [Resolved] (VELTOOLS-136) SortTool fails on null values

2018-06-25 Thread Claude Brisson (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Brisson resolved VELTOOLS-136. - Resolution: Fixed Assignee: Claude Brisson The sorting methods (which are now

[jira] [Resolved] (VELTOOLS-164) EscapeTool#url() does not escape the '&' character

2018-06-25 Thread Claude Brisson (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Brisson resolved VELTOOLS-164. - Resolution: Cannot Reproduce Assignee: Claude Brisson There isn't any

[jira] [Closed] (VELTOOLS-164) EscapeTool#url() does not escape the '&' character

2018-06-25 Thread Claude Brisson (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Brisson closed VELTOOLS-164. --- > EscapeTool#url() does not escape the '&' character >

[jira] [Resolved] (VELTOOLS-155) SerializationException in the package org.apache.velocity.tools.generic.*

2018-06-25 Thread Claude Brisson (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Brisson resolved VELTOOLS-155. - Resolution: Fixed Assignee: Claude Brisson Fix Version/s: 3.0 All

Cannot build Tools from trunk

2018-06-25 Thread Michael Osipov
Folks, who is able to Tools from trunk? I cannot with Java 8 and 10: [INFO] --- cargo-maven2-plugin:1.6.8:start (start-server) @ velocity-tools-examples-showcase --- [INFO] [2.ContainerStartMojo] Resolved container artifact org.codehaus.cargo:cargo-core-container-jetty:jar:1.6.8 for

[jira] [Resolved] (VELTOOLS-141) VelocityView Servlet does not handle NULL templates

2018-06-25 Thread Claude Brisson (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Brisson resolved VELTOOLS-141. - Resolution: Won't Fix Assignee: Claude Brisson As Christopher suggested, the

[jira] [Closed] (VELTOOLS-141) VelocityView Servlet does not handle NULL templates

2018-06-25 Thread Claude Brisson (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Brisson closed VELTOOLS-141. --- > VelocityView Servlet does not handle NULL templates >

[jira] [Closed] (VELTOOLS-165) Hyperlink error on

2018-06-25 Thread Claude Brisson (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Brisson closed VELTOOLS-165. --- > Hyperlink error on > --- > > Key: VELTOOLS-165 >

[jira] [Resolved] (VELTOOLS-165) Hyperlink error on

2018-06-25 Thread Claude Brisson (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Brisson resolved VELTOOLS-165. - Resolution: Fixed Assignee: Claude Brisson Fix Version/s: 2.0 Fixed in

[jira] [Closed] (VELTOOLS-147) Website Documenting Generic Tools list is missing Viewtool name and link to document

2018-06-25 Thread Claude Brisson (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Brisson closed VELTOOLS-147. --- Fixed some time ago on the site. > Website Documenting Generic Tools list is missing Viewtool

[jira] [Resolved] (VELTOOLS-147) Website Documenting Generic Tools list is missing Viewtool name and link to document

2018-06-25 Thread Claude Brisson (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Brisson resolved VELTOOLS-147. - Resolution: Fixed > Website Documenting Generic Tools list is missing Viewtool name

[jira] [Closed] (VELTOOLS-140) No proper pom.xml file on maven central for velocity-tools 1.4

2018-06-25 Thread Claude Brisson (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Brisson closed VELTOOLS-140. --- > No proper pom.xml file on maven central for velocity-tools 1.4 >

[jira] [Resolved] (VELTOOLS-140) No proper pom.xml file on maven central for velocity-tools 1.4

2018-06-25 Thread Claude Brisson (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Brisson resolved VELTOOLS-140. - Resolution: Fixed Assignee: Claude Brisson It has been taken care of.   > No

[jira] [Resolved] (VELTOOLS-157) Race condition when instantiating tools

2018-06-25 Thread Claude Brisson (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Brisson resolved VELTOOLS-157. - Resolution: Fixed Assignee: Claude Brisson Fix Version/s: 3.0 Fixed in

[jira] [Closed] (VELTOOLS-169) Upgrade commons-collections compile dependency to v3.2.2 or v4.1

2018-06-25 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed VELTOOLS-169. --- Resolution: Won't Fix Fix Version/s: (was: 3.0) Nothing to fix here in 3.0

[jira] [Updated] (VELOCITY-853) Upgrade dependency to commons-collections4

2018-06-25 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated VELOCITY-853: Fix Version/s: (was: 2.0) > Upgrade dependency to commons-collections4 >

[jira] [Reopened] (VELTOOLS-169) Upgrade commons-collections compile dependency to v3.2.2 or v4.1

2018-06-25 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reopened VELTOOLS-169: - > Upgrade commons-collections compile dependency to v3.2.2 or v4.1 >

[jira] [Updated] (VELTOOLS-125) StrutsLinkTool are returning the full url the action. Problem with reverse proxy applications because $link.Action() most be return the context path only.

2018-06-25 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated VELTOOLS-125: Fix Version/s: (was: 3.0) > StrutsLinkTool are returning the full url the action.

[jira] [Closed] (VELTOOLS-172) Remove dependency on Apache Commons Validator

2018-06-25 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed VELTOOLS-172. --- > Remove dependency on Apache Commons Validator >

[jira] [Updated] (VELTOOLS-126) XSS Vulnerability when using struts/ErrorsTool.getMsgs

2018-06-25 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated VELTOOLS-126: Fix Version/s: (was: 3.0) > XSS Vulnerability when using struts/ErrorsTool.getMsgs >

[jira] [Updated] (VELTOOLS-138) StrutsLinkTool breaks paths containing a query string

2018-06-25 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated VELTOOLS-138: Fix Version/s: (was: 3.0) > StrutsLinkTool breaks paths containing a query string >

[jira] [Closed] (VELTOOLS-170) Upgrade beanutils to 1.9.3 & supress access to class and Class

2018-06-25 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed VELTOOLS-170. --- > Upgrade beanutils to 1.9.3 & supress access to class and Class >

[jira] [Closed] (VELTOOLS-171) Remove Struts dependency

2018-06-25 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed VELTOOLS-171. --- > Remove Struts dependency > > > Key: VELTOOLS-171 >

[jira] [Closed] (VELTOOLS-161) allow session toolbox serialization

2018-06-25 Thread Michael Osipov (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed VELTOOLS-161. --- > allow session toolbox serialization > --- > >