[veltools 2] Javadoc typo?

2007-11-01 Thread Christopher Schultz
Nathan, While looking at org.apache.velocity.tools.view.LinkTool in the 2.x branch, I see that the tool says Since VelocityTools 1.0. I wanted to ask if you should change that to 2.0 since this class didn't exist until the 2.x branch. On the other hand, the tool itself LinkTool has existed since

Re: [veltools 2] Javadoc typo?

2007-11-01 Thread Nathan Bubna
On 11/1/07, Christopher Schultz [EMAIL PROTECTED] wrote: Nathan, While looking at org.apache.velocity.tools.view.LinkTool in the 2.x branch, I see that the tool says Since VelocityTools 1.0. I wanted to ask if you should change that to 2.0 since this class didn't exist until the 2.x branch.

[Velocity Wiki] Update of VelocityTools2/VelocityView by NathanBubna

2007-11-01 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on Velocity Wiki for change notification. The following page has been changed by NathanBubna: http://wiki.apache.org/velocity/VelocityTools2/VelocityView

[Velocity Wiki] Update of VelocityTools2/VelocityStruts by NathanBubna

2007-11-01 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on Velocity Wiki for change notification. The following page has been changed by NathanBubna: http://wiki.apache.org/velocity/VelocityTools2/VelocityStruts

[veltools] Alternate behavior for LinkTool's new addAllParameters capability

2007-11-01 Thread Christopher Schultz
All, Nathan and I have just added addAllParameters capability to the LinkTool (including explicit ignoring of current-request parameters) and I started thinking about the Struts 2 behavior which is to automatically ignore any parameter from the current request that has already been set on the

[Velocity Wiki] Update of VelocityTools2/VelocityStruts by NathanBubna

2007-11-01 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on Velocity Wiki for change notification. The following page has been changed by NathanBubna: http://wiki.apache.org/velocity/VelocityTools2/VelocityStruts

Re: [veltools] Alternate behavior for LinkTool's new addAllParameters capability

2007-11-01 Thread Nathan Bubna
+1 I think it makes sense that the default would be to ignore actively set params. On 11/1/07, Christopher Schultz [EMAIL PROTECTED] wrote: All, Nathan and I have just added addAllParameters capability to the LinkTool (including explicit ignoring of current-request parameters) and I started

[jira] Created: (VELTOOLS-89) LinkTool's addQueryData method should automatically add an 'ignore' so addAllParameters will ignore manually-added query data

2007-11-01 Thread Christopher Schultz (JIRA)
LinkTool's addQueryData method should automatically add an 'ignore' so addAllParameters will ignore manually-added query data - Key: VELTOOLS-89

[jira] Closed: (VELTOOLS-88) LinkTool could easily be modified to support current-request parameter duplication

2007-11-01 Thread Christopher Schultz (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Schultz closed VELTOOLS-88. --- Fix verified. LinkTool could easily be modified to support current-request parameter

[jira] Closed: (VELTOOLS-75) Add MessageTool.get method that accepts an explicit Locale

2007-11-01 Thread Christopher Schultz (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Schultz closed VELTOOLS-75. --- Fix verified. Add MessageTool.get method that accepts an explicit Locale

[veltools] Toolbox parameters

2007-11-01 Thread Christopher Schultz
All, Any given tool gets an init(Object) call before it gets used. For view tools, that object is a ViewContext. How can I pass configuration parameters from the toolbox.xml file into the tools via the ViewContext object? It looks like the only attribute really used is the XHTML one, but that's

Re: [veltools] Toolbox parameters

2007-11-01 Thread Nathan Bubna
On 11/1/07, Christopher Schultz [EMAIL PROTECTED] wrote: All, Any given tool gets an init(Object) call before it gets used. For view tools, that object is a ViewContext. How can I pass configuration parameters from the toolbox.xml file into the tools via the ViewContext object? For Veltools

Re: [veltools] Toolbox parameters

2007-11-01 Thread Christopher Schultz
Nathan, Nathan Bubna wrote: For Veltools 1.x, in the tool: public void configure(Map params) { //TODO: extract and use params here } I'm an idiot. I totally missed that method and focused all my concentration on the init() method instead. Is there any particular reason that these two

[jira] Updated: (VELTOOLS-89) LinkTool's addQueryData method should automatically add an 'ignore' so addAllParameters will ignore manually-added query data

2007-11-01 Thread Christopher Schultz (JIRA)
[ https://issues.apache.org/jira/browse/VELTOOLS-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Schultz updated VELTOOLS-89: Attachment: VELTOOLS-89.diff This patch adds to LinkTool: - Automatic additions

Re: [veltools] Toolbox parameters

2007-11-01 Thread Nathan Bubna
On 11/1/07, Christopher Schultz [EMAIL PROTECTED] wrote: Nathan, Nathan Bubna wrote: For Veltools 1.x, in the tool: public void configure(Map params) { //TODO: extract and use params here } I'm an idiot. I totally missed that method and focused all my concentration on the init()