Re: svn commit: r517553 [1/2] - in

2007-03-13 Thread Will Glass-Husain
How so? I moved ParserVisitor back into the node package, where it was in v1.4. Since it's not part of the public API, shouldn't matter. (Am I right?) We got into trouble with this before by moving the Node object, which is part of the Directive API. WILL On 3/13/07, Henning P.

Re: svn commit: r517553 [1/2] - in

2007-03-13 Thread Nathan Bubna
I agree that this is not part of the public API, and i'm ok with the change. However, we need to make sure this is very well-documented, so that those who do more heavy hacking on Velocity get warning of the change. And, if it's easy/trivial to add a deprecation path, that wouldn't hurt

Re: svn commit: r517553 [1/2] - in

2007-03-13 Thread Will Glass-Husain
The problem is that JavaCC overwrites this file, thus it's actually not easy to keep it unchanged. So I think deprecation is too difficult here. I'll add a note to the Javadoc. WILL On 3/13/07, Nathan Bubna [EMAIL PROTECTED] wrote: I agree that this is not part of the public API, and i'm ok