Re: Rework AttributeModifier to deprecate AttributeAppender and SimpleAttributeModifier

2011-06-09 Thread Martijn Dashorst
In short: AttributeModifier can get a lot simpler: - always add the attribute (unless the AM is disabled) - the regexp matching functionality needs to go - replaceModel needs to become an Object (with instanceof check for models) - enabled field should be removed in favor of subclassing and

Re: Rework AttributeModifier to deprecate AttributeAppender and SimpleAttributeModifier

2011-06-09 Thread Clint Checketts
So AttributeAppender and SimpleAttributeModifier will not be deprecated? On Thu, Jun 9, 2011 at 10:24 AM, Martijn Dashorst martijn.dasho...@gmail.com wrote: I've committed the rework for 1.5, which doesn't completely rework AttirubteModifier and friends, but sets the stage for 1.6. I didn't