Re: Opinion about the change proposed in WICKET-4326 ?

2012-01-11 Thread Martin Grigorov
On Tue, Jan 10, 2012 at 12:21 PM, Emond Papegaaij emond.papega...@topicus.nl wrote: I'm +0 for the rename. I understand that IAjaxRequestHandler is a better name than AjaxRequestTarget, but it also involves quite a lot of work from our users to fix their apps. You have to remember that they

Re: [vote] release wicket 1.5.4

2012-01-11 Thread Sven Meier
+1 Am 10.01.2012 20:03, schrieb Igor Vaynberg: This vote is to release wicket 1.5.4 Branch http://git-wip-us.apache.org/repos/asf/wicket/?p=wicket.git;a=shortlog;h=refs/heads/build/wicket-1.5.4 Artifacts http://people.apache.org/~ivaynberg/wicket-1.5.4/dist/ Maven repo

Re: Externalized Page Flow in Wicket

2012-01-11 Thread vasanth
Hi Clint, We have a similar requirement where we want to externalize the page flow to work with Spring Web Flow. Have you shared the integration layer anywhere or do you have any write up on how you did this? Thanks. --Vasanth -- View this message in context:

Re: Opinion about the change proposed in WICKET-4326 ?

2012-01-11 Thread Igor Vaynberg
im all for removing the I anyways, so +1 from me -igor On Wed, Jan 11, 2012 at 12:27 AM, Martin Grigorov mgrigo...@apache.org wrote: On Tue, Jan 10, 2012 at 12:21 PM, Emond Papegaaij emond.papega...@topicus.nl wrote: I'm +0 for the rename. I understand that IAjaxRequestHandler is a better

Re: Externalized Page Flow in Wicket

2012-01-11 Thread Clint Checketts
Yes, I uploaded it with no fanfare to the 1.4 branch of wicket-stuff and intended to port it to 1.5 then make an announcement. But since you asked here is the code: https://github.com/wicketstuff/core/tree/core-1.4.x/jdk-1.5-parent/spring-webflow-parent You can see an example app in the

Re: Opinion about the change proposed in WICKET-4326 ?

2012-01-11 Thread tetsuo
No, please not another breaking change just for the sake of it. It's cheap to rename things that exist in your codebase and you hit 'Ctrl+Shift+R', and Eclipse does it all for you. It's not that cheap to fix safely (which 'find|grep|wc' is not!) thousands of compiler errors spread across hundreds

Re: Opinion about the change proposed in WICKET-4326 ?

2012-01-11 Thread tetsuo
Oh, or just remove the 'final' from the methods! (I can suggest a number of other cases it could also be done) On Wed, Jan 11, 2012 at 8:32 PM, tetsuo ronald.tet...@gmail.com wrote: No, please not another breaking change just for the sake of it. It's cheap to rename things that exist in your

Re: Externalized Page Flow in Wicket

2012-01-11 Thread vasanth
Thanks a lot for sharing. I will take a look at the code. -- View this message in context: http://apache-wicket.1842946.n4.nabble.com/Externalized-Page-Flow-in-Wicket-tp3515182p4287174.html Sent from the Forum for Wicket Core developers mailing list archive at Nabble.com.

Re: [vote] release wicket 1.5.4

2012-01-11 Thread Emond Papegaaij
-1 The change for WICKET-4290 breaks links on mounted pages when page parameters are used. I've added 2 testcases to illustrate the problem: http://git-wip- us.apache.org/repos/asf?p=wicket.git;a=commit;h=f5cae9496a9918d958c034cea18d5ff3f168d7d5 Emond On Tuesday 10 January 2012 11:03:17 Igor