Page implements IRedirectListener

2014-02-20 Thread Martin Grigorov
Hi, I have the following patch here: -public abstract class Page extends MarkupContainer implements IRedirectListener, IRequestablePage +public abstract class Page extends MarkupContainer implements IRequestablePage { /** True if the page hierarchy has been modified in the current

Re: Page implements IRedirectListener

2014-02-20 Thread Martin Grigorov
I've missed RedirectPage in my search the first time. Thanks! Here is a better version: diff --git i/wicket-core/src/main/java/org/apache/wicket/markup/html/pages/RedirectPage.java w/wicket-core/src/main/java/org/apache/wicket/markup/html/pages/RedirectPage.java index 9b60bea..57f6f1f 100644 ---

Re: Page implements IRedirectListener

2014-02-20 Thread Ernesto Reinaldo Barreiro
Martin, Glad to be of some help. Also markup of RedirectPage.html !DOCTYPE HTML PUBLIC -//W3C//DTD HTML 4.01 Transitional//EN http://www.w3.org/TR/html4/loose.dtd; html xmlns:wicket=http://wicket.apache.org;headmeta wicket:id=redirect http-equiv=refresh content=0; url=app//head/html might be

Re: Page implements IRedirectListener

2014-02-20 Thread Sven Meier
Since #onRedirect() is final currently, I'm +1 to remove IRedirectListener. Sven On 02/20/2014 11:03 AM, Martin Grigorov wrote: I've missed RedirectPage in my search the first time. Thanks! Here is a better version: diff --git

[ANNOUNCE] Apache Wicket 6.14.0 is released

2014-02-20 Thread Andrea Del Bene
This is the fourteenth maintenance release of the Wicket 6.x series. This release brings 25 bug fixes and improvements. Git tag: release/wicket-6.14.0 Changelog: https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12325860styleName=projectId=12310561 Maven: dependency

Re: Page implements IRedirectListener

2014-02-20 Thread Ernesto Reinaldo Barreiro
IMHO removing final would be the correct thing: this could be useful in case a user wants to do something on a page when they are redirected from another. Sample use case. 1- I have a (mounted) page with some functionality. I have used this page for some e-mail or some URL user keep.. 2- I have

Re: Page implements IRedirectListener

2014-02-20 Thread Martin Grigorov
On Thu, Feb 20, 2014 at 2:02 PM, Ernesto Reinaldo Barreiro reier...@gmail.com wrote: IMHO removing final would be the correct thing: this could be useful in case a user wants to do something on a page when they are redirected from another. Sample use case. 1- I have a (mounted) page with

Re: Page implements IRedirectListener

2014-02-20 Thread Ernesto Reinaldo Barreiro
I do agree On Thu, Feb 20, 2014 at 1:07 PM, Martin Grigorov mgrigo...@apache.orgwrote: On Thu, Feb 20, 2014 at 2:02 PM, Ernesto Reinaldo Barreiro reier...@gmail.com wrote: IMHO removing final would be the correct thing: this could be useful in case a user wants to do something on a page

Re: [2/2] git commit: WICKET-3335 nested borders working. everything should be working. needs more cleanup and javadoc

2014-02-20 Thread Igor Vaynberg
On Tue, Feb 18, 2014 at 4:53 AM, Martin Grigorov mgrigo...@apache.org wrote: On Sat, Feb 15, 2014 at 9:40 AM, ivaynb...@apache.org wrote: WICKET-3335 nested borders working. everything should be working. needs more cleanup and javadoc Project: