Hi Peter,
I'm glad to see you again here!
Are you sure that Clirr has problems ?
BuildBot has failed with the JS tests because we use hardcoded value of the
port where NodeJS's connect server binds to.
master branch acquired the port and wicket-6.x failed to bind it.
I think your change is OK
Hi,
The main problem I see with this is that we cannot cover all possible names.
1) It is possible to create custom HTML elements in JavaScript. So the list
of names should be easy to extend
2) with Web Components standard custom names are used even more often
3) and yes, some users use Wicket to
Hi Andrea,
On Wed, Jul 16, 2014 at 8:33 PM, adelb...@apache.org wrote:
Repository: wicket
Updated Branches:
refs/heads/master c24d830cd - bb9c1044e
Code beautifying: method WebPageRenderer.respond
What exactly beautifying means ?
It is a bit hard to see what is the actual change. It
Not a Java or Wicket article, but interesting nonetheless:
http://inessential.com/2014/07/14/string_constants
I'm not a big fan of putting everything in constants in a central
location. We won't be changing an anchor tag from a to anchor across
all code in Wicket, ever.
There has to be a benefit
Method respond had high level of if...else nesting, a couple of them
useless. in which way the new code doesn't respect Wicket's code format?
Maybe my IDE did something wrong.
Hi Andrea,
On Wed, Jul 16, 2014 at 8:33 PM, adelb...@apache.org wrote:
Repository: wicket
Updated Branches:
what is/was useless ?
now I am even more confused what your beautification did with this really
important and fragile part of Wicket code :-)
I'm not saying that the new code is badly formatted. I was asking whether
beautification really means code formatting
Martin Grigorov
Wicket Training and
OK. Thanks!
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Thu, Jul 17, 2014 at 5:53 PM, Andrea Del Bene an.delb...@gmail.com
wrote:
I admit I've changed a very sensible part of the code :), however after
working with it I realized that we could reduce its
You spotted me :)! I could also use pmd rules to make it clear from the
start:
http://pmd.sourceforge.net/pmd-4.3/rules/design.html#AvoidDeeplyNestedIfStmts
You just removed two pairs of curly braces (to turn 'else { if {} }'
into 'else if {}') and re-indented the code?
“The truth is rarely
On Thu, Jul 17, 2014 at 9:08 AM, Garret Wilson gar...@globalmentor.com wrote:
On 7/17/2014 8:25 AM, Martin Grigorov wrote:
...
For some reason this feature doesn't seem that usable to me...
Could you be more specific about why you don't find this feature doesn't
seem useful? None of your
All,
I was just notified that my 3 proposals for presentations about Wicket
were accepted. Apparently I have some work to do...
My proposals are below.
Hope to see you there!
Martijn
Apache Wicket: 10 years and beyond
With the Tenth Anniversary of Wicket behind us, Wicket is still one of
the
Sweet! I hope you share your slides (and maybe even recorded video?) with
the world!
On Thu, Jul 17, 2014 at 4:53 PM, Martijn Dashorst
martijn.dasho...@gmail.com wrote:
All,
I was just notified that my 3 proposals for presentations about Wicket
were accepted. Apparently I have some work to
On 17 July 2014 17:43, Igor Vaynberg igor.vaynb...@gmail.com wrote:
On Thu, Jul 17, 2014 at 9:08 AM, Garret Wilson gar...@globalmentor.com
wrote:
On 7/17/2014 8:25 AM, Martin Grigorov wrote:
...
For some reason this feature doesn't seem that usable to me...
Could you be more
12 matches
Mail list logo
