Re: [wicket8] Use default method for IModel#detach()?

2017-03-27 Thread Sven Meier
Hi Pedro, >Why don't we make AbstractReadyOnlyModel the superinterface of IModel IIRC Michael Mosmann tried to work on something similar but it never quite worked out. Do you want to work on a proposal? Before you invest too much time into this: I'm pretty sure most devs won't be in favor

Re: wicket git commit: WICKET-6347 added #detach() to all renderers

2017-03-27 Thread Martin Grigorov
Hi Sven, One minor issue: the renderer is optional (i.e. null-able) in some classes, so you will have to check before calling its #detach() method. For example in AjaxEditableChoiceLabel Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Mon, Mar 27, 2017 at 5:28

Re: [wicket8] Use default method for IModel#detach()?

2017-03-27 Thread Pedro Santos
Neither I am sure I understand you. By dating the email thread and the IModel interface hierarchy you mean that by them being old we can't discuss their merit? I meant that IModel isn't a functional interface, not that it isn't annotated as one. Same for the setObject method not having a default

Re: [wicket8] Use default method for IModel#detach()?

2017-03-27 Thread Martin Grigorov
Hi Pedro, I am not sure I understand you! This discussion was 1.5 years ago ... On Mon, Mar 27, 2017 at 1:39 AM, Pedro Santos wrote: > -0 > > I see no good reason for IModel to extend from IDetachable. Users should be > able to add this interface at their will. > IModel