Re: Proposal to remove IDetachable from IModel hierarchy

2017-03-29 Thread Pedro Santos
Hi Emond, > It is an integral part of the lifecycle of IModel Most of the models in Wicket and Wicketstuff have no detach logic, hardly an integral part. > One could say that the sole purpose of the detach traversal is to detach all models. Wicket detaches all components in the page in

[ANNOUNCE] WicketStuff 8.0.0-M5 Released

2017-03-29 Thread Martin Grigorov
WicketStuff core 8.0.0-M5 based on Apache Wicket 8.0.0-M5 is released and soon will be available at Maven Central! The changelog since 8.0.0-M4 is: Maxim Solodovnik (8): org.json import is replaced with com.github.openjson, build is partially fixed org.json import is replaced with

[ANNOUNCE] Apache Wicket 8.0.0-M5 Released

2017-03-29 Thread Andrea Del Bene
The Apache Wicket PMC is proud to announce Apache Wicket 8.0.0-M5! Apache Wicket is an open source Java component oriented web application framework that powers thousands of web applications and web sites for governments, stores, universities, cities, banks, email providers, and more. You can

Re: Proposal to remove IDetachable from IModel hierarchy

2017-03-29 Thread Martin Grigorov
Fully agree with Emond! As a user I will hate such kind of change. Several years ago this change might be OKish, but now with Java 8 default methods it would be insane to break everyone's code when default methods make it invisible. Until 7.x I'd have to add empty impl for detach() when I don't

Re: [VOTE] Release Apache Wicket 8.0.0-M5

2017-03-29 Thread Andrea Del Bene
This vote passes with 6 votes plus 1 non-binding Thank you! On 29/03/2017 12:03, Andrea Del Bene wrote: +1 release 8.0.0-M5 Randomly tested example from war file. On Tue, Mar 28, 2017 at 4:29 PM, Sven Meier > wrote: +1 release 8.0.0-M5

[GitHub] wicket pull request #217: [Fix] setRequired checked for primitive type only ...

2017-03-29 Thread JoachimRohde
GitHub user JoachimRohde opened a pull request: https://github.com/apache/wicket/pull/217 [Fix] setRequired checked for primitive type only when the FormCompon… …ent was NOT required See https://issues.apache.org/jira/browse/WICKET-6350 You can merge this pull request into

Re: Proposal to remove IDetachable from IModel hierarchy

2017-03-29 Thread Emond Papegaaij
Hi Pedro, I fail to see why it is a problem for IModel to be IDetachable. It is an integral part of the lifecycle of IModel. One could say that the sole purpose of the detach traversal is to detach all models. A model knows how to retrieve data, update data and to detach its internal

Re: Proposal to remove IDetachable from IModel hierarchy

2017-03-29 Thread Pedro Santos
>From user's perspective this is a symmetrical problem. This sadness is carried over to an user in the other side, in need to avoid any detach logic or processing in his component or model if the target model isn't detachable. Right know he would have to come up with his own marker e.g.:

Re: Question regarding new AjaxDownload (WICKET-6286)

2017-03-29 Thread Maxim Solodovnik
Will try to migrate all my use cases on a SNAPSHOT first Then will do Thanks Martin! On Wed, Mar 29, 2017 at 9:28 PM, Martin Grigorov wrote: > Maxim, you can use Location.IFrame or Location.SameWindow too in -M5 (to be > released!). > > Martin Grigorov > Wicket Training and

Re: Question regarding new AjaxDownload (WICKET-6286)

2017-03-29 Thread Martin Grigorov
Maxim, you can use Location.IFrame or Location.SameWindow too in -M5 (to be released!). Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Wed, Mar 29, 2017 at 4:26 PM, Sven Meier wrote: > In a minute :P > > Sven > > > > On 29.03.2017 16:15,

Re: Question regarding new AjaxDownload (WICKET-6286)

2017-03-29 Thread Sven Meier
In a minute :P Sven On 29.03.2017 16:15, Andrea Del Bene wrote: Right when we will return to "success" :-) https://ci.apache.org/builders/wicket-master On Wed, Mar 29, 2017 at 4:07 PM, Maxim Solodovnik wrote: Wow, Thanks a lot! Could you please let me know when

Re: Question regarding new AjaxDownload (WICKET-6286)

2017-03-29 Thread Andrea Del Bene
you're wellcome On Wed, Mar 29, 2017 at 4:20 PM, Maxim Solodovnik wrote: > Now I know where to check :) > Thanks! > > On Wed, Mar 29, 2017 at 9:15 PM, Andrea Del Bene > wrote: > > Right when we will return to "success" :-) > > > >

Re: Question regarding new AjaxDownload (WICKET-6286)

2017-03-29 Thread Maxim Solodovnik
Now I know where to check :) Thanks! On Wed, Mar 29, 2017 at 9:15 PM, Andrea Del Bene wrote: > Right when we will return to "success" :-) > > https://ci.apache.org/builders/wicket-master > > On Wed, Mar 29, 2017 at 4:07 PM, Maxim Solodovnik > wrote: >

Re: Question regarding new AjaxDownload (WICKET-6286)

2017-03-29 Thread Andrea Del Bene
Right when we will return to "success" :-) https://ci.apache.org/builders/wicket-master On Wed, Mar 29, 2017 at 4:07 PM, Maxim Solodovnik wrote: > Wow, Thanks a lot! > Could you please let me know when SNAPSHOT with the fix will be available? > > On Wed, Mar 29, 2017 at

Re: Question regarding new AjaxDownload (WICKET-6286)

2017-03-29 Thread Maxim Solodovnik
Wow, Thanks a lot! Could you please let me know when SNAPSHOT with the fix will be available? On Wed, Mar 29, 2017 at 8:50 PM, Sven Meier wrote: > Hi, > > so we have to change the Location.Blob to use XMLHttpRequest directly, > because jQuery does not support blob downloads :/.

Proposal to remove IDetachable from IModel hierarchy

2017-03-29 Thread Pedro Santos
Hi team, Not every model is detachable, but right now all models extends from IDetachable because this contract is forced to any implementation for IModel. The only way users have to communicate their model isn't detachable, for their own purpose, is by creating their own mechanism; but I think

Re: Question regarding new AjaxDownload (WICKET-6286)

2017-03-29 Thread Sven Meier
Hi, so we have to change the Location.Blob to use XMLHttpRequest directly, because jQuery does not support blob downloads :/. I've change the JavaScript and now downloading of the zip works fine. FileSystemResource might not be the best candidate (because it's not serializable), but you can

Re: Question regarding new AjaxDownload (WICKET-6286)

2017-03-29 Thread Martin Grigorov
On Wed, Mar 29, 2017 at 3:12 PM, Maxim Solodovnik wrote: > Filename is minor issue > Main problem is invalid file :( > > How can I serve the file from file system? I thought filesystemreference if > the best candidate . > If ResourceBehavior#onRequest() is not

Re: Question regarding new AjaxDownload (WICKET-6286)

2017-03-29 Thread Maxim Solodovnik
Filename is minor issue Main problem is invalid file :( How can I serve the file from file system? I thought filesystemreference if the best candidate . WBR, Maxim (from mobile, sorry for the typos) On Mar 29, 2017 8:08 PM, "Sven Meier" wrote: > Hi Maxim, > > three

Re: Question regarding new AjaxDownload (WICKET-6286)

2017-03-29 Thread Sven Meier
Hi Maxim, three things: - filename ... no one sets the file name :P - serializable error ... FileSystemResource holds a reference to the path, which is not serializable - corruct zip ... my bad, it seems that Location.Blob mangles the file on the client side I'll see what I can do about

Re: Question regarding new AjaxDownload (WICKET-6286)

2017-03-29 Thread Maxim Solodovnik
here you are: https://github.com/solomax/ajax-download Absolutely don't understand what is going on :( On Wed, Mar 29, 2017 at 6:30 PM, Maxim Solodovnik wrote: > Yep, zip file is valid > Breakpoint at AjaxDownload.ResourceBehavior#onRequest() is not hit :( > Will try to