Re: wicket-ajax.js cleanup

2019-05-03 Thread Sven Meier
JS Tests are not built each time, so npm is not a requirement to build Wicket. I'd like to keep it that way. Sven > > On 03.05.2019 at 16:52,wrote: > > > Right. There is not issue with build then. сб, 4 мая 2019 г. в 00:39, Martin > Grigorov :

Re: wicket-ajax.js cleanup

2019-05-03 Thread Andrew Kondratev
Right. There is not issue with build then. сб, 4 мая 2019 г. в 00:39, Martin Grigorov : > On Fri, May 3, 2019, 15:36 Emond Papegaaij > wrote: > > > Hi, > > > > We use the frontend-maven-plugin, which automatically downloads and > > installs > > node as part of your maven build. It works quite

Re: wicket-ajax.js cleanup

2019-05-03 Thread Martin Grigorov
On Fri, May 3, 2019, 15:36 Emond Papegaaij wrote: > Hi, > > We use the frontend-maven-plugin, which automatically downloads and > installs > node as part of your maven build. It works quite ok. > This is what Wicket JS tests uses as well. > Emond > > On vrijdag 3 mei 2019 11:56:14 CEST Andrew

Re: wicket-ajax.js cleanup

2019-05-03 Thread Emond Papegaaij
Hi, We use the frontend-maven-plugin, which automatically downloads and installs node as part of your maven build. It works quite ok. Emond On vrijdag 3 mei 2019 11:56:14 CEST Andrew Kondratev wrote: > Thank you. I understand these concerns. > > Speaking about performance concern, if node is

Re: wicket-ajax.js cleanup

2019-05-03 Thread Andrew Kondratev
Thank you. I understand these concerns. Speaking about performance concern, if node is available on machine and modules are installed it takes less than 3 seconds to build on my laptop from 2013, incomparable with entire wicket build time. However, with node installation and modules installation

[GitHub] [wicket] d3ns0n closed pull request #355: WICKET-6660 do not trim PasswordTextField input

2019-05-03 Thread GitBox
d3ns0n closed pull request #355: WICKET-6660 do not trim PasswordTextField input URL: https://github.com/apache/wicket/pull/355 This is an automated message from the Apache Git Service. To respond to the message, please log

Re: wicket-ajax.js cleanup

2019-05-03 Thread Martin Grigorov
On Fri, May 3, 2019 at 9:32 AM Sven Meier wrote: > > > Hi, > > > > yes, we could get rid of some crufty code here. > > > > But before you put too much effort into this: > > Do we really want to blow up our build with npm/typescript just to > generate ~3000 lines of code? > > I doubt that it's

Re: wicket-ajax.js cleanup

2019-05-03 Thread Sven Meier
Hi, yes, we could get rid of some crufty code here. But before you put too much effort into this: Do we really want to blow up our build with npm/typescript just to generate ~3000 lines of code? I doubt that it's worth it. The code is very stable and well tested anyway.