Re: discussion on modernisation of wicket's front-end code

2019-05-05 Thread Andrew Kondratev
Hi! I hope everyone had a great weekend! I tried to add a frontend-maven-plugin to do the TS build inside of maven build by simply enabling `ts-transpile` and it works pretty well. Also committed a resulting wicket-ajax-jquery.js. A resulting code looks very similar to original. Here's the

Re: wicket-ajax.js cleanup

2019-05-05 Thread Andrew Kondratev
The package-lock.json could be git ignored if changes in the dependencies tree do not matter a lot. It exists mostly for convenience, to help developers know if something has changed in dependencies. пн, 6 мая 2019 г. в 08:56, Emond Papegaaij : > On vrijdag 3 mei 2019 17:16:02 CEST Sven Meier

Re: wicket-ajax.js cleanup

2019-05-05 Thread Emond Papegaaij
On vrijdag 3 mei 2019 17:16:02 CEST Sven Meier wrote: > JS Tests are not built each time, so npm is not a requirement to build > Wicket. I'd like to keep it that way. With the frontend-maven-plugin it isn't required to have it installed on your system. The plugin will download node and npm as

[GitHub] [wicket] martin-g commented on issue #356: Wicket 6662

2019-05-05 Thread GitBox
martin-g commented on issue #356: Wicket 6662 URL: https://github.com/apache/wicket/pull/356#issuecomment-489462577 @bitstorm My reasoning is: If the classes are public then they have to be deprecated before being removed. There is no way to tell how many applications use any of those

[GitHub] [wicket] bitstorm commented on issue #356: Wicket 6662

2019-05-05 Thread GitBox
bitstorm commented on issue #356: Wicket 6662 URL: https://github.com/apache/wicket/pull/356#issuecomment-489436880 @martin-g normally I would do the same thing, but to me these are more classes for internal uses. I don't think many people use them directly with Wicket. Once we remove

[GitHub] [wicket] bitstorm edited a comment on issue #356: Wicket 6662

2019-05-05 Thread GitBox
bitstorm edited a comment on issue #356: Wicket 6662 URL: https://github.com/apache/wicket/pull/356#issuecomment-489436880 @martin-g normally I would do the same thing, but to me these are more classes for internal use. I don't think many people use them directly with Wicket. Once we