[ANNOUNCE] WicketStuff 8.7.0 Released

2020-01-10 Thread Maxim Solodovnik
WicketStuff core 8.7.0 based on Apache Wicket 8.7.0 is released and soon will be available at Maven Central! The changelog is: Andrea Del Bene (1): Response content type set as first step. Christoph Jost (1): fix for list flattening #685 Martin Tzvetanov Grigorov (2): Issue

[ANNOUNCE] WicketStuff 7.16.0 Released

2020-01-10 Thread Maxim Solodovnik
WicketStuff core 7.16.0 based on Apache Wicket 7.16.0 is released and soon will be available at Maven Central! The changelog is: Maxim Solodovnik (4): Switching to the next development version Jamon tests are fixed Some dependencies are updated wicketstuff-core-7.16.0 is

Re: Jakarta EE 8 vs Java EE 8 APIs

2020-01-10 Thread Emond Papegaaij
I've prepared a branch 'jakarta-api' with the migration to Jakarta, Servlet 4 and Jetty 10.0.0-alpha1. Most of the examples work fine, however I get an NPE on the websocket upgrade: Caused by: java.lang.NullPointerException at

Re: Jakarta EE 8 vs Java EE 8 APIs

2020-01-10 Thread Martin Grigorov
On Fri, Jan 10, 2020 at 4:03 PM Emond Papegaaij wrote: > I tend to agree with Martijn here. The Jakarta APIs are the future. It > is unfortunate that the last stable version of Jetty is 4 years old > now and they have not been able to produce a new version in the past 2 > years. Maybe us moving

Re: Jakarta EE 8 vs Java EE 8 APIs

2020-01-10 Thread Emond Papegaaij
I tend to agree with Martijn here. The Jakarta APIs are the future. It is unfortunate that the last stable version of Jetty is 4 years old now and they have not been able to produce a new version in the past 2 years. Maybe us moving to servlet 4 will give them a bit more incentive to pick op the

Re: Jakarta EE 8 vs Java EE 8 APIs

2020-01-10 Thread Jeroen Steenbeeke
Most of my Wicket applications (i.e. the ones I don't get paid to write) run on Jetty 9.4, Java 11 and Wicket 8. Jetty 10 is, as indicated on the site I linked, still in alpha and marked as unstable, and has no official Docker image yet. Right now there is nothing blocking me from adopting

Re: Jakarta EE 8 vs Java EE 8 APIs

2020-01-10 Thread Martin Grigorov
On Fri, Jan 10, 2020 at 3:29 PM Martijn Dashorst wrote: > On Fri, Jan 10, 2020 at 2:09 PM Jeroen Steenbeeke > wrote: > > > > Jetty is still on 3.1: > > > > > https://www.eclipse.org/jetty/documentation/current/what-jetty-version.html > > Well, Emond was talking about the major

Re: Jakarta EE 8 vs Java EE 8 APIs

2020-01-10 Thread Martijn Dashorst
On Fri, Jan 10, 2020 at 2:09 PM Jeroen Steenbeeke wrote: > > Jetty is still on 3.1: > > https://www.eclipse.org/jetty/documentation/current/what-jetty-version.html Well, Emond was talking about the major application/servlet containers :-D... As we are targeting Java 11 with Wicket 9, perhaps

Re: Jakarta EE 8 vs Java EE 8 APIs

2020-01-10 Thread Jeroen Steenbeeke
Jetty is still on 3.1: https://www.eclipse.org/jetty/documentation/current/what-jetty-version.html Op vr 10 jan. 2020 om 14:05 schreef Emond Papegaaij < emond.papega...@gmail.com>: > It turns out Wicket 9 is still on servlet 3.1, which is pre-Jakarta. > Any objections against raising this to

Re: Jakarta EE 8 vs Java EE 8 APIs

2020-01-10 Thread Emond Papegaaij
It turns out Wicket 9 is still on servlet 3.1, which is pre-Jakarta. Any objections against raising this to 4.0? AFAIK all major application/servlet containers have versions with support for 4.0. Best regards, Emond On Fri, Jan 10, 2020 at 1:04 PM Martijn Dashorst wrote: > > Just the maven

Re: Jakarta EE 8 vs Java EE 8 APIs

2020-01-10 Thread Martijn Dashorst
Just the maven coordinates. As for expected problems: probably folks have to update their poms to use the jakarta variants, but mostly they shouldn't bite if they use the provided scope. For benefits: - the Jakarta group-id is the future, all servers will move to that maven coordinate - the

Re: Building with JDK 14 ea

2020-01-10 Thread Maxim Solodovnik
there is failOnError option https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-mojo.html#failOnError It can be turned on :)) On Fri, 10 Jan 2020 at 17:27, Emond Papegaaij wrote: > Indeed, the build does not fail, it barfs various nasty errors and > ends with 'BUILD SUCCESS' :) It

Re: Jakarta EE 8 vs Java EE 8 APIs

2020-01-10 Thread Martin Grigorov
Hi Emond, If it is just about different Maven coordinates then it is OK. For the change javax.servlet -> jakarta.servlet it is too soon. On Fri, Jan 10, 2020 at 12:40 PM Emond Papegaaij wrote: > Hi all, > > While building our application against Wicket 9, I noticed Wicket > still uses the Java

Re: Jakarta EE 8 vs Java EE 8 APIs

2020-01-10 Thread Andrea Del Bene
I'm tempted to say "yes, let's move to Jakarta", but I'm not sure about the consequences. Could it be a problem with web servers (Jetty, Tomcat)? Do they have a minimum version required to work with Jakarta? On Fri, Jan 10, 2020 at 11:40 AM Emond Papegaaij wrote: > Hi all, > > While building

Jakarta EE 8 vs Java EE 8 APIs

2020-01-10 Thread Emond Papegaaij
Hi all, While building our application against Wicket 9, I noticed Wicket still uses the Java EE 8 APIs. I would like to change these to the Jakarta versions. The APIs themselves are completely identical, it is just the maven coordinate that changes. They do however come with a better license

Re: Building with JDK 14 ea

2020-01-10 Thread Emond Papegaaij
Indeed, the build does not fail, it barfs various nasty errors and ends with 'BUILD SUCCESS' :) It does however not build the javadoc. I've filed https://issues.apache.org/jira/browse/MJAVADOC-633 Best regards, Emond On Fri, Jan 10, 2020 at 10:19 AM Martin Grigorov wrote: > > On Fri, Jan 10,

Re: Building with JDK 14 ea

2020-01-10 Thread Martin Grigorov
On Fri, Jan 10, 2020 at 11:12 AM Martin Grigorov wrote: > > > On Fri, Jan 10, 2020 at 11:02 AM Martin Grigorov > wrote: > >> >> >> On Fri, Jan 10, 2020 at 10:58 AM Maxim Solodovnik >> wrote: >> >>> `clean package` sounds more reasonable to me :) >>> >> >> agreed, but let's change that only

Re: buildbot failure in on wicket-master-java12

2020-01-10 Thread Martin Grigorov
I will remove the java12 build On Thu, Jan 9, 2020 at 12:34 PM Tobias Soloschenko wrote: > +1 to remove JDK 12 testing > > kind regards > > Tobias > > > Am 09.01.2020 um 09:52 schrieb Maxim Solodovnik : > > > > I would vote for removing JDK12 > > no need to test outdated non-LTS versions IMO >

Re: Building with JDK 14 ea

2020-01-10 Thread Martin Grigorov
On Fri, Jan 10, 2020 at 11:02 AM Martin Grigorov wrote: > > > On Fri, Jan 10, 2020 at 10:58 AM Maxim Solodovnik > wrote: > >> `clean package` sounds more reasonable to me :) >> > > agreed, but let's change that only once we have a fix/workaround for the > problem > it seems it does not break

Re: Building with JDK 14 ea

2020-01-10 Thread Martin Grigorov
On Fri, Jan 10, 2020 at 10:58 AM Maxim Solodovnik wrote: > `clean package` sounds more reasonable to me :) > agreed, but let's change that only once we have a fix/workaround for the problem > > On Fri, 10 Jan 2020 at 15:57, Maxim Solodovnik > wrote: > > > `fast` profile skips javadoc >

Re: Building with JDK 14 ea

2020-01-10 Thread Martin Grigorov
On Fri, Jan 10, 2020 at 10:58 AM Maxim Solodovnik wrote: > `fast` profile skips javadoc > right! this explains it > > On Fri, 10 Jan 2020 at 15:56, Martin Grigorov > wrote: > > > Hi Emond, > > > > Locally while testing new JDK builds I always use: mvn14 clean install > > -Pfast,java14 >

Re: Building with JDK 14 ea

2020-01-10 Thread Maxim Solodovnik
`clean package` sounds more reasonable to me :) On Fri, 10 Jan 2020 at 15:57, Maxim Solodovnik wrote: > `fast` profile skips javadoc > > On Fri, 10 Jan 2020 at 15:56, Martin Grigorov > wrote: > >> Hi Emond, >> >> Locally while testing new JDK builds I always use: mvn14 clean install >>

Re: Building with JDK 14 ea

2020-01-10 Thread Maxim Solodovnik
`fast` profile skips javadoc On Fri, 10 Jan 2020 at 15:56, Martin Grigorov wrote: > Hi Emond, > > Locally while testing new JDK builds I always use: mvn14 clean install > -Pfast,java14 > mvn14 script just exports JAVA_HOME=$JAVA_14_HOME and calls mvn > and I don't remember having issues

Re: Building with JDK 14 ea

2020-01-10 Thread Martin Grigorov
Hi Emond, Locally while testing new JDK builds I always use: mvn14 clean install -Pfast,java14 mvn14 script just exports JAVA_HOME=$JAVA_14_HOME and calls mvn and I don't remember having issues with javadoc since a long time. On Fri, Jan 10, 2020 at 10:45 AM Emond Papegaaij wrote: > Hi all, >