Hi Maxim,
On Wed, Jan 15, 2020 at 8:54 AM Maxim Solodovnik
wrote:
> Hello All,
>
> According to my tests
> textarea with hidden attribute works the same way as `display: none`
> (latest Chrome, FF, Chromium)
>
What exactly did you test ?
According to
Hello All,
According to my tests
textarea with hidden attribute works the same way as `display: none`
(latest Chrome, FF, Chromium)
hidden also hides all descendants
So I would vote for using `hidden="hidden"` for placeholders and preserving
`data-wicket-placeholder`
(due to hidden can be used
Hi Everyone!
Is this "none !important" actually needed? Elements with hidden attribute
are hidden by themselves, except the cases when they have some display
overrides (see
https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/hidden).
If developer/user does override he or she could
Hi Edmond,
then I'll ask again:
Why not render a "hidden" attribute and style it in the core css:
|[hidden] { display: none !important}|
We could get rid of the "data-wicket-placeholder" attribute as well, and
let wicket-ajax check on the "hidden" attribute instead.
Sven
On 14.01.20
Hi Maxim,
great idea with the header contributor, that's much better!
Thanks
Sven
On 14.01.20 16:23, Maxim Solodovnik wrote:
For example it can be added as
`Application.get().getHeaderContributorListeners()`
On Tue, 14 Jan 2020 at 16:03, Maxim Solodovnik wrote:
`!important` is not the
> >Using the hidden attribute is no option either,
> >because it is overridden by any css that sets display.
>
> why is that a no-option, hidden elements can be styled too:
Dropping the styling altogether will force our users to package their
own styling for artifacts generated by Wicket. These
Hi,
>Using the hidden attribute is nooption either,
>because it is overridden by any css that sets display.
why is that a no-option, hidden elements can be styled too:
|[hidden] { display: none !important} |
Do you mean FormComponentFeedbackBorder's "color:red;" style?
I wouldn't want that to
Hi,
Sven, we do need styling to hide components.
Component.renderPlaceholderTag renders an empty tag for whatever it
reads from your markup. That fact that it is empty, does not mean it
is invisible. For example, in my application I had empty list-items
(li) popping up all over the place. Using
Hi Maxim,
an empty div with hidden inputs does not take any space.
Try it with wicket-examples.
Have fun
Sven
Am 14. Januar 2020 18:07:23 MEZ schrieb Maxim Solodovnik :
>I thought the main idea is to keep placeholder for any element both
>invisible and "take no space"
>hidden attribute might
I thought the main idea is to keep placeholder for any element both
invisible and "take no space"
hidden attribute might work instead of `display: none`
The latter also hides all descendants [1], so I guess it should be
preferable
[1] https://developer.mozilla.org/en-US/docs/Web/CSS/display
On
Hi,
do we really need this CSS?
AFAIK the 'hidden' markup from Form and Component placeholders do not
need any styling actually, they look fine without it.
We should add a CSS class to the markup of course, but leave its styling
to each project.
Cases in wicket-examples (UploadProgressBar,
For example it can be added as
`Application.get().getHeaderContributorListeners()`
On Tue, 14 Jan 2020 at 16:03, Maxim Solodovnik wrote:
> `!important` is not the silver bullet (as well as inline style)
>
> `renderHead` is not as important as `onConfigure`, so I believe it
> shouldn't be made
8.x has been updated to 8.7.0. I've also created a Docker image for
9.0.0-M4 on Bintray and a relative PR for infra team to create a new domain
for 9.x examples.
https://github.com/apache/infrastructure-puppet/pull/1708
Andrea.
On Mon, Jan 13, 2020 at 12:45 PM Andrea Del Bene
wrote:
> I
`!important` is not the silver bullet (as well as inline style)
`renderHead` is not as important as `onConfigure`, so I believe it
shouldn't be made mandatory
Maybe there is some `hackish` way to inject this css only once for any
component hierarchy?
On Tue, 14 Jan 2020 at 15:55, Emond Papegaaij
On Tue, Jan 14, 2020 at 9:16 AM Maxim Solodovnik
wrote:
> Is this comment make sense:
>
> https://github.com/apache/wicket/commit/6d91a6a9e5c1d955a53571f9fb0f76262ac5c5d2#r36784645
> ?
>
Sounds good to me!
>
> On Tue, 14 Jan 2020 at 14:13, Martin Grigorov
> wrote:
>
> > On Tue, Jan 14, 2020
On Tue, Jan 14, 2020 at 10:01 AM Maxim Solodovnik
wrote:
> An related question:
> Will this code
>
> `org.apache.wicket.core.util.string.ComponentRenderer.renderComponent(Component)`
> work as expected?
>
This method will render the component with class="wicket--hidden" on its
HTML element.
An related question:
Will this code
`org.apache.wicket.core.util.string.ComponentRenderer.renderComponent(Component)`
work as expected?
On Tue, 14 Jan 2020 at 14:15, Maxim Solodovnik wrote:
> Is this comment make sense:
>
17 matches
Mail list logo
