Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-15 Thread Andrew Kondratev
Some kind of core CSS is likely to be needed, considering that ALL inline styles should go not just hidden/display:none. The special class is what I originally suggested. For me personally the approach with css class would be easier to live with. Another option to consider could be an inline

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-15 Thread Sven Meier
Hi Andrew, exactly what I was thinking. Have fun Sven On 14.01.20 22:55, Andrew Kondratev wrote: Hi Everyone! Is this "none !important" actually needed? Elements with hidden attribute are hidden by themselves, except the cases when they have some display overrides (see

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-15 Thread Emond Papegaaij
> > IMHO we have to decide first whether we want to use the "hidden" attribute. > > I'm not sure about the pros and cons at the moment. > > > > Depending on that decision (NO) we'll have to write CSS classes anyway > > or (YES) we might want to add them additionally. > > In the latter case I'm not

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-15 Thread Martin Grigorov
On Wed, Jan 15, 2020 at 8:12 PM Sven Meier wrote: > Hi Martin, > > IMHO we have to decide first whether we want to use the "hidden" attribute. > I'm not sure about the pros and cons at the moment. > > Depending on that decision (NO) we'll have to write CSS classes anyway > or (YES) we might want

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-15 Thread Sven Meier
Hi Martin, IMHO we have to decide first whether we want to use the "hidden" attribute. I'm not sure about the pros and cons at the moment. Depending on that decision (NO) we'll have to write CSS classes anyway or (YES) we might want to add them additionally. In the latter case I'm not sure we

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-15 Thread Sven Meier
Hi, in my tests inputs inside of hidden divs work just fine. >This sounds like if you use 'hidden' attribute on a that wraps some >form elements, those elements will submit their values when you submit >their form. With display:none the elements won't submit their values. Actually elements

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-15 Thread Sven Meier
I disagree, "hidden" has the perfect semantic for what we're doing with placeholders or other s. Sven On 15.01.20 11:44, Emond Papegaaij wrote: According to my tests textarea with hidden attribute works the same way as `display: none` (latest Chrome, FF, Chromium) Maxim and Andrew: Yes,

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-15 Thread Maxim Solodovnik
Just have tested Chrome might change the position of such tag in the DOM :( (inside table) sorry for the noise On Wed, 15 Jan 2020 at 23:54, Maxim Solodovnik wrote: > Maybe some non-html tag can be rendered as placeholder? (for ex. > ) > It will be invisible :) > > > On Wed, Jan 15, 2020,

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-15 Thread Maxim Solodovnik
Maybe some non-html tag can be rendered as placeholder? (for ex. ) It will be invisible :) On Wed, Jan 15, 2020, 17:44 Emond Papegaaij wrote: > > > According to my tests > > > textarea with hidden attribute works the same way as `display: none` > > > (latest Chrome, FF, Chromium) > > > > >

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-15 Thread Emond Papegaaij
> > According to my tests > > textarea with hidden attribute works the same way as `display: none` > > (latest Chrome, FF, Chromium) > > Maxim and Andrew: Yes, the display: none is very important. (That's why it even has !important). The hidden attribute has the lowest priority possible. Any

Re: [wicket] branch csp updated: WICKET-6725: replace display:none by wicket--hidden css class

2020-01-15 Thread Maxim Solodovnik
Hello Martin, I did more tests :) Browser Chrome latest plain HTML 4 tabs enter different text in all areas via DevTools 1) first