[GitHub] [wicket] papegaaij opened a new pull request #402: WICKET-6731: Inline JS in SubmitLink

2020-01-24 Thread GitBox
papegaaij opened a new pull request #402: WICKET-6731: Inline JS in SubmitLink URL: https://github.com/apache/wicket/pull/402 This PR moves the inline JS in SubmitLink to an event handler. @martin-g You mentioned that we might need to call `setOutputMarkupId(true)`, but I haven't

Re: [wicket] branch csp updated: WICKET-6731: move inline onclick to event handler

2020-01-24 Thread Emond Papegaaij
Isn't renderHead always called before rendering the component itself? getMarkupId() already causes setOutputMarkupId(true). When the head isn't always rendered before the component itself, then you are right. Emond On Fri, Jan 24, 2020 at 3:13 PM Martin Grigorov wrote: > > On Fri, Jan 24, 2020

Re: [wicket] branch csp updated: WICKET-6731: move inline onclick to event handler

2020-01-24 Thread Martin Grigorov
On Fri, Jan 24, 2020 at 3:50 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > papegaaij pushed a commit to branch csp > in repository https://gitbox.apache.org/repos/asf/wicket.git > > > The following commit(s) were added to refs/heads/csp by this push: >

Re: build of master branch failed because of date format

2020-01-24 Thread Maxim Solodovnik
Thanks :) On Fri, 24 Jan 2020 at 18:14, Andrea Del Bene wrote: > and in the meantime 11.0.6 has been released :-) > > On Fri, Jan 24, 2020 at 11:42 AM Andrea Del Bene > wrote: > > > I've already opened it back in November: > > > > https://issues.apache.org/jira/browse/INFRA-19481 > > > > maybe

Re: build of master branch failed because of date format

2020-01-24 Thread Andrea Del Bene
and in the meantime 11.0.6 has been released :-) On Fri, Jan 24, 2020 at 11:42 AM Andrea Del Bene wrote: > I've already opened it back in November: > > https://issues.apache.org/jira/browse/INFRA-19481 > > maybe we can send a friendly reminder. > > On Fri, Jan 24, 2020 at 8:35 AM Martin

[GitHub] [wicket] asfgit merged pull request #401: WICKET-6726: remove inline styling and javascript from Form

2020-01-24 Thread GitBox
asfgit merged pull request #401: WICKET-6726: remove inline styling and javascript from Form URL: https://github.com/apache/wicket/pull/401 This is an automated message from the Apache Git Service. To respond to the

Re: build of master branch failed because of date format

2020-01-24 Thread Andrea Del Bene
I've already opened it back in November: https://issues.apache.org/jira/browse/INFRA-19481 maybe we can send a friendly reminder. On Fri, Jan 24, 2020 at 8:35 AM Martin Grigorov wrote: > Hi Maxim, > > This must be because of an old build of JDK11 on BuildBot. > Let's open a ticket at INFRA to

[GitHub] [wicket] papegaaij commented on issue #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-24 Thread GitBox
papegaaij commented on issue #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#issuecomment-578071603 @andruhon Per page to works fine in my application. This is an

[GitHub] [wicket] andruhon commented on issue #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-24 Thread GitBox
andruhon commented on issue #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#issuecomment-578056988 Hi Emond I also had difficulties with nonce per request and went with per-session solution. On Fri, 24 Jan 2020 at

[GitHub] [wicket] papegaaij commented on issue #399: WICKET-6727: Configurable Content-Security-Policy

2020-01-24 Thread GitBox
papegaaij commented on issue #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#issuecomment-578047350 I just noticed a problem with using a different nonce for every response. strict-dynamic only works for scripts and not for

[GitHub] [wicket] martin-g commented on issue #401: WICKET-6726: remove inline styling and javascript from Form

2020-01-24 Thread GitBox
martin-g commented on issue #401: WICKET-6726: remove inline styling and javascript from Form URL: https://github.com/apache/wicket/pull/401#issuecomment-578029949 Thank you, @papegaaij ! This is an automated message from