[GitHub] [wicket] papegaaij commented on issue #399: WICKET-6727: Configurable Content-Security-Policy

2020-02-06 Thread GitBox
papegaaij commented on issue #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#issuecomment-583267013 @solomax I was planning to wrap this up today. I want to run some more tests with our application, now that most issues in wicket

[GitHub] [wicket] solomax commented on issue #399: WICKET-6727: Configurable Content-Security-Policy

2020-02-06 Thread GitBox
solomax commented on issue #399: WICKET-6727: Configurable Content-Security-Policy URL: https://github.com/apache/wicket/pull/399#issuecomment-583224053 @papegaaij is it time to merge this PR into master? This is an

Re: Form submit via Javascript and event handlers

2020-02-06 Thread Emond Papegaaij
I've fixed the commit message, thanks for the feedback. Emond On Thu, Feb 6, 2020 at 1:05 PM Martin Grigorov wrote: > > Looks good! > > One nit: the commit message mentions twice > 'should*Trigger*JavaScriptSubmitEvent' > while the latter should be 'should*Invoke*JavaScriptFormOnsubmit' > You

Re: Form submit via Javascript and event handlers

2020-02-06 Thread Martin Grigorov
Looks good! One nit: the commit message mentions twice 'should*Trigger*JavaScriptSubmitEvent' while the latter should be 'should*Invoke*JavaScriptFormOnsubmit' You can fix it in 'csp' branch before merging to master On Wed, Feb 5, 2020 at 11:22 PM Emond Papegaaij wrote: > This is what I have

Re: Form submit via Javascript and event handlers

2020-02-06 Thread Sven Meier
Fine by me. Sven On 05.02.20 22:22, Emond Papegaaij wrote: This is what I have in mind: https://github.com/apache/wicket/commit/b54938053a5bda2f4577966779d580e828f16e47 I think this is better than the old situation because this triggers any submit handlers on the form (or any parent element