Re: WICKET-6725 styling of hidden elements: no vote yet

2020-02-26 Thread Tobias Soloschenko
Hi, as you know I am a big fan of HTML5 and was experimenting a lot with it, I would also vote to stay with a core css and clean it up, because of a better backward compatibility. flex is used a LOT in modern layouts and would break the other option. kind regards Tobias > Am 26.02.2020 um

[GitHub] [wicket] reiern70 commented on a change in pull request #410: [WICKET-6750] allow to abort currently executing request for a given …

2020-02-26 Thread GitBox
reiern70 commented on a change in pull request #410: [WICKET-6750] allow to abort currently executing request for a given … URL: https://github.com/apache/wicket/pull/410#discussion_r384522325 ## File path:

[GitHub] [wicket] reiern70 commented on a change in pull request #410: [WICKET-6750] allow to abort currently executing request for a given …

2020-02-26 Thread GitBox
reiern70 commented on a change in pull request #410: [WICKET-6750] allow to abort currently executing request for a given … URL: https://github.com/apache/wicket/pull/410#discussion_r384522677 ## File path:

[GitHub] [wicket] reiern70 commented on a change in pull request #410: [WICKET-6750] allow to abort currently executing request for a given …

2020-02-26 Thread GitBox
reiern70 commented on a change in pull request #410: [WICKET-6750] allow to abort currently executing request for a given … URL: https://github.com/apache/wicket/pull/410#discussion_r384522325 ## File path:

[GitHub] [wicket] reiern70 opened a new pull request #410: [WICKET-6750] allow to abort currently executing request for a given …

2020-02-26 Thread GitBox
reiern70 opened a new pull request #410: [WICKET-6750] allow to abort currently executing request for a given … URL: https://github.com/apache/wicket/pull/410 allow to abort currently executing request for a given Ajax channel + example

Re: WICKET-6725 styling of hidden elements: no vote yet

2020-02-26 Thread Martijn Dashorst
On Wed, Feb 26, 2020 at 11:15 AM Emond Papegaaij wrote: > > On Tue, Feb 25, 2020 at 10:54 PM Sven Meier wrote: > > > - it's a kitchen-sink for left-over styles (see .wicket--color-red) > > > > I agree that for this one Wicket can just add the CSS class (e.g. > > wicket-feedback-indicator) on

Re: WICKET-6725 styling of hidden elements: no vote yet

2020-02-26 Thread Martijn Dashorst
On Tue, Feb 25, 2020 at 9:54 PM Sven Meier wrote: > [] leave as is with .wicket--hidden & wicket-core.css > > [] use HTML5 "hidden" attribute instead > While it is true that Wicket hasn't depended on a CSS file for its own use, it has been dependent on its own styles, spread out through our

Re: WICKET-6725 styling of hidden elements: no vote yet

2020-02-26 Thread Emond Papegaaij
On Wed, Feb 26, 2020 at 10:53 AM Martin Grigorov wrote: > I am also not big fan of CSP but users ask for it and I see no other way > but to move all inline styles in such .css resource IMHO CSP is one of the changes to the web application ecosystem that Wicket will need an answer on to stay

[GitHub] [wicket] reiern70 commented on a change in pull request #409: [WICKET-6750] allow to abort currently executing AJAX request

2020-02-26 Thread GitBox
reiern70 commented on a change in pull request #409: [WICKET-6750] allow to abort currently executing AJAX request URL: https://github.com/apache/wicket/pull/409#discussion_r384385873 ## File path: wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js

Re: WICKET-6725 styling of hidden elements: no vote yet

2020-02-26 Thread Martin Grigorov
Hi Sven, On Tue, Feb 25, 2020 at 10:54 PM Sven Meier wrote: > Hi all, > > we have a disagreement on how to style hidden elements in Wicket 9.x. > > Due to the new CSP support we can no longer use inline styling to hide > elements. > WICKET-6725 introduces new CSS classes and a file

[GitHub] [wicket] reiern70 commented on a change in pull request #409: [WICKET-6750] allow to abort currently executing AJAX request

2020-02-26 Thread GitBox
reiern70 commented on a change in pull request #409: [WICKET-6750] allow to abort currently executing AJAX request URL: https://github.com/apache/wicket/pull/409#discussion_r384373648 ## File path: wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js

Re: WICKET-6725 styling of hidden elements: no vote yet

2020-02-26 Thread Ernesto Reinaldo Barreiro
Hi, Right now I have no enough knowledge to vote in this feature. One thing I didn't like, and I already mentioned it before, is some of us were waiting for 9.x to be released some time ago (at least a few months ago I was preparing some branch of our application and ported it to 9.x, after

Re: WICKET-6725 styling of hidden elements: no vote yet

2020-02-26 Thread Maxim Solodovnik
[+] leave as is with .wicket--hidden & wicket-core.css IMO we should sheep the version which will work as expected out-of-the-box According to my tests `hidden` attribute doesn't work (even `display: flex` breaks it) On Wed, 26 Feb 2020 at 15:22, Andrea Del Bene wrote: > > +1 to vote. I find

Re: WICKET-6725 styling of hidden elements: no vote yet

2020-02-26 Thread Andrea Del Bene
+1 to vote. I find your concerns legitimate On Tue, Feb 25, 2020 at 9:54 PM Sven Meier wrote: > Hi all, > > we have a disagreement on how to style hidden elements in Wicket 9.x. > > Due to the new CSP support we can no longer use inline styling to hide > elements. > WICKET-6725 introduces new