Re: Why jakarta.enterprise.cdi-api has "provided" scope ?

2020-03-12 Thread Maxim Solodovnik
Maybe this dependency can be added to dependencies of jetty-maven-plugin ? On Thu, 12 Mar 2020 at 23:23, Martin Grigorov wrote: > > On Thu, Mar 12, 2020, 16:41 Martijn Dashorst > wrote: > > > Because it is, just like the servlet-api, a specification that is provided > > by the container. When

Re: CSPRequestCycleListener headers

2020-03-12 Thread Sven Meier
Hi Emond, for me setting the appropriate headers is part of rendering. I've just tried setting HTTP CSP headers from CSPNonceHeaderResponseDecorator, and that almost works (with minor changes to HtmlHeaderContainer, which currently doesn't allow setting of headers during rendering). Before

Re: Why jakarta.enterprise.cdi-api has "provided" scope ?

2020-03-12 Thread Martin Grigorov
On Thu, Mar 12, 2020, 16:41 Martijn Dashorst wrote: > Because it is, just like the servlet-api, a specification that is provided > by the container. When your container does not supply that specification, > you have to override the scope yourself and supply the API that way. E.G. > Wildfly

Re: Why jakarta.enterprise.cdi-api has "provided" scope ?

2020-03-12 Thread Martijn Dashorst
Because it is, just like the servlet-api, a specification that is provided by the container. When your container does not supply that specification, you have to override the scope yourself and supply the API that way. E.G. Wildfly supplies that API, as does Glassfish, etc. The examples could

Re: WICKET-6725 styling of hidden elements: no vote yet

2020-03-12 Thread Sven Meier
Hi all, I've looked at all responses and most arguments in favor of a "core.css" boil down to: > `hidden` attribute doesn't work (even `display: flex` breaks it) > Using the hidden attribute puts the responsibility with the developer > where this should be on the framework. The hidden

Why jakarta.enterprise.cdi-api has "provided" scope ?

2020-03-12 Thread Martin Grigorov
Hi, Does anyone know why jakarta.enterprise:jakarta.enterprise.cdi-api dependency [1] has provided scope in dependency management ? I'm hitting NoClassDefFoundError for javax.enterprise.inject.spi.BeanManager while deploying wicket-examples.war in Tomcat. 1.

Re: CSPRequestCycleListener headers

2020-03-12 Thread Martin Grigorov
On Thu, Mar 12, 2020 at 3:34 PM Martin Grigorov wrote: > > > On Thu, Mar 12, 2020 at 3:03 PM Emond Papegaaij > wrote: > >> Hi Sven, >> >> Yes, you might be right. When rendering another page, normally the >> header will be overridden when the second handler is resolved. >> However, this will

Re: CSPRequestCycleListener headers

2020-03-12 Thread Martin Grigorov
On Thu, Mar 12, 2020 at 3:03 PM Emond Papegaaij wrote: > Hi Sven, > > Yes, you might be right. When rendering another page, normally the > header will be overridden when the second handler is resolved. > However, this will not happen when the page is not protected > (protectedPageFilter). Do you

Re: CSPRequestCycleListener headers

2020-03-12 Thread Emond Papegaaij
Hi Sven, Yes, you might be right. When rendering another page, normally the header will be overridden when the second handler is resolved. However, this will not happen when the page is not protected (protectedPageFilter). Do you see a solution for this? Maybe recording the desired action in the

CSPRequestCycleListener headers

2020-03-12 Thread Sven Meier
Hi Emond, it seems to me the CSPRequestCycleListener might add CSP headers prematurely. What if a request comes in for one page and another page is rendered in response? The listener will already add the headers when the request handler is resolved for the former page. What if the page

Re: [VOTE] Release Apache Wicket 9.0.0-M5

2020-03-12 Thread Sven Meier
Hi, I don't care about the method name, so I reverted it to #getCspSettings(). AFAIKS the documentation stays valid in that case? Have fun Sven On 12.03.20 09:42, Emond Papegaaij wrote: Hi, Agreed, but first, the documentation needs to be updated with the new API. I like most of the

Re: [VOTE] Release Apache Wicket 9.0.0-M5

2020-03-12 Thread Andrea Del Bene
This vote is cancelled. +1 for getCspSettings from me too On 3/12/20 9:53 AM, Maxim Solodovnik wrote: +1 for getCspSettings But I guess it will be M5 ... :) On Thu, 12 Mar 2020 at 15:42, Emond Papegaaij wrote: Hi, Agreed, but first, the documentation needs to be updated with the new API.

Re: [VOTE] Release Apache Wicket 9.0.0-M5

2020-03-12 Thread Maxim Solodovnik
+1 for getCspSettings But I guess it will be M5 ... :) On Thu, 12 Mar 2020 at 15:42, Emond Papegaaij wrote: > > Hi, > > Agreed, but first, the documentation needs to be updated with the new > API. I like most of the changes, except for the new method name for >

Re: [VOTE] Release Apache Wicket 9.0.0-M5

2020-03-12 Thread Emond Papegaaij
Hi, Agreed, but first, the documentation needs to be updated with the new API. I like most of the changes, except for the new method name for 'getContentSecurityPolicySettings()'. IMHO it's too long and everyone calls it CSP. I'd rather stick with 'getCspSettings()'. The documentation in

Re: [VOTE] Release Apache Wicket 9.0.0-M5

2020-03-12 Thread Martin Grigorov
Hi, Sven just made some API breaking changes with https://gitbox.apache.org/repos/asf?p=wicket.git;h=88e8d36, for good! If we want the next release to be the final one then I suggest to cancel this vote and start over with the new change. Martin On Tue, Mar 10, 2020 at 10:50 PM Andrea Del Bene