Re: Incorrect modification time in jars

2023-12-06 Thread Maxim Solodovnik
File timestamps might be set to `project.build.outputTimestamp` by Maven This enables "reproducible builds" https://maven.apache.org/guides/mini/guide-reproducible-builds.html I believe Maven `project.build.outputTimestamp` property should be set in the pom.xml by release manager during release

Re: Incorrect modification time in jars

2023-12-06 Thread Emond Papegaaij
> > > > https://github.com/apache/wicket/blob/a68536eb095bb5cf59e4063b6af9436523ddc623/wicket-core/src/main/java/org/apache/wicket/settings/ResourceSettings.java#L650-L664 > LastModifiedResourceVersion is used in DEV mode by default. > MessageDigestResourceVersion is for PROD. > Yes, I know. I

Re: Incorrect modification time in jars

2023-12-06 Thread Martin Grigorov
On Wed, Dec 6, 2023 at 7:45 PM Emond Papegaaij wrote: > Op wo 6 dec 2023 18:22 schreef Richard Eckart de Castilho >: > > > > We can switch from LastModifiedResourceVersion to something else in our > > > applications to work around this issue, but maybe we should consider > > > tracking down

Re: Incorrect modification time in jars

2023-12-06 Thread Emond Papegaaij
Op wo 6 dec 2023 18:22 schreef Richard Eckart de Castilho : > > We can switch from LastModifiedResourceVersion to something else in our > > applications to work around this issue, but maybe we should consider > > tracking down this issue and release a 9.16.1. I'd expect we are not the > > only

Re: Incorrect modification time in jars

2023-12-06 Thread Richard Eckart de Castilho
Hi, > On 6. Dec 2023, at 16:48, Emond Papegaaij wrote: > > We can switch from LastModifiedResourceVersion to something else in our > applications to work around this issue, but maybe we should consider > tracking down this issue and release a 9.16.1. I'd expect we are not the > only ones using

Incorrect modification time in jars

2023-12-06 Thread Emond Papegaaij
Hi, With the upgrade to wicket 9.16.0 we've seen some issues with the new 'Wicket.Event.requestSubmit' method that was added to wicket-ajax-jquery. It turns out that a cached version of the resource was used, and this seems to be caused by an incorrect version string in the url. The filename is

Re: Wicket 10(-M?) checkpoint

2023-12-06 Thread Vit Rozkovec
On 06. 12. 23 13:08, Martin Grigorov wrote: The reason is SameSite support - https://github.com/apache/wicket/commit/f0b4b1b3b63f33e12c8b2b04e22fcf73b773ec34 It is easy for us to fix the version in the wiki! How easy is it for you to use a container that supports Servlet API 6 ?

Re: Wicket 10(-M?) checkpoint

2023-12-06 Thread Martin Grigorov
On Wed, Dec 6, 2023 at 2:08 PM Martin Grigorov wrote: > > > On Wed, Dec 6, 2023 at 12:40 PM Vit Rozkovec wrote: > >> Hi, >> in parent pom.xml you are referencing >> 6.0.0 >> >> but here you state that Servlet 5+ is required: >> >>

Re: Wicket 10(-M?) checkpoint

2023-12-06 Thread Martin Grigorov
On Wed, Dec 6, 2023 at 12:40 PM Vit Rozkovec wrote: > Hi, > in parent pom.xml you are referencing > 6.0.0 > > but here you state that Servlet 5+ is required: > > https://cwiki.apache.org/confluence/display/WICKET/Migration+to+Wicket+10.0#MigrationtoWicket10.0-Wicket10requiresServlet5+ > > I've

Re: Wicket 10(-M?) checkpoint

2023-12-06 Thread Vit Rozkovec
Hi, in parent pom.xml you are referencing 6.0.0 but here you state that Servlet 5+ is required: https://cwiki.apache.org/confluence/display/WICKET/Migration+to+Wicket+10.0#MigrationtoWicket10.0-Wicket10requiresServlet5+ I've been bitten by this today when users couldn't sign in the app as