Re: [VOTE] Release Apache Wicket 7.8.1 take 2

This vote is canceled. We need more time to tackle PageStore issues (WICKET-6465 WICKET-6467). Once they are solved it might be better to release a minor version (7.9.0) rather than a fix. On Wed, Sep 6, 2017 at 3:27 PM, Andrea Del Bene wrote: > +1 to release > > Checked

Re: [VOTE] Release Apache Wicket 7.8.1 take 2

+1 to release Checked user guide examples and source archive for the fix. On Wed, Sep 6, 2017 at 2:14 PM, Martin Grigorov wrote: > On Wed, Sep 6, 2017 at 10:18 AM, Emond Papegaaij < > emond.papega...@topicus.nl > > wrote: > > > I've checked the source and noticed

Re: [VOTE] Release Apache Wicket 7.8.1 take 2

On Wed, Sep 6, 2017 at 10:18 AM, Emond Papegaaij wrote: > I've checked the source and noticed wicket/testing/wicket- > arquillian/pom.xml > has version 7.8.0. What do we want to do with that? We've released > artifacts > with version 7.0.0, 7.1.0, 7.2.0, 7.7.0, 7.8.0

Re: [VOTE] Release Apache Wicket 7.8.1 take 2

+ 1 to release Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Tue, Sep 5, 2017 at 11:17 PM, Andrea Del Bene wrote: > This is a vote to release Apache Wicket 7.8.1 > > Please download the source distributions found in our staging area >

Re: [VOTE] Release Apache Wicket 7.8.1 take 2

I've checked the source and noticed wicket/testing/wicket-arquillian/pom.xml has version 7.8.0. What do we want to do with that? We've released artifacts with version 7.0.0, 7.1.0, 7.2.0, 7.7.0, 7.8.0 and 8.0.0 for this module. It seems the version has been off before. The binary tar.gz does

Re: [VOTE] Release Apache Wicket 7.8.1 take 2

+1 kind regards Tobias > Am 05.09.2017 um 22:17 schrieb Andrea Del Bene : > > This is a vote to release Apache Wicket 7.8.1 > > Please download the source distributions found in our staging area > linked below. > > I have included the signatures for both the source

[VOTE] Release Apache Wicket 7.8.1 take 2

This is a vote to release Apache Wicket 7.8.1 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source archives. This vote lasts for 72 hours minimum. [ ] Yes, release Apache Wicket 7.8.1 [ ] No, don't release Apache

Re: [VOTE] Release Apache Wicket 7.8.1

Yes, I think that's better than trying to rush a fix for the form submit. The issue with the page store is quite severe and needs a fix. Best regards, Emond On dinsdag 5 september 2017 13:00:54 CEST Andrea Del Bene wrote: > If it's ok I will rebuild a new 7.8.1 starting from the 7.8.0 tag and >

Re: [VOTE] Release Apache Wicket 7.8.1

If it's ok I will rebuild a new 7.8.1 starting from the 7.8.0 tag and applying only the fix for the page store. On Tue, Sep 5, 2017 at 11:45 AM, Andrea Del Bene wrote: > This vote fails due to a bug WICKET-6462 discovered by Francois Meillet > > On Tue, Sep 5, 2017 at

Re: [VOTE] Release Apache Wicket 7.8.1

This vote fails due to a bug WICKET-6462 discovered by Francois Meillet On Tue, Sep 5, 2017 at 11:44 AM, Andrea Del Bene wrote: > @Martin > > I agree! > > On Mon, Sep 4, 2017 at 9:55 PM, Martin Grigorov > wrote: > >> -1 to release >> >> but before

Re: [VOTE] Release Apache Wicket 7.8.1

@Martin I agree! On Mon, Sep 4, 2017 at 9:55 PM, Martin Grigorov wrote: > -1 to release > > but before making a new release let's add Francois' app as a test case to > prevent regressions. > > Martin Grigorov > Wicket Training and Consulting >

Re: [VOTE] Release Apache Wicket 7.8.1

-1 to release but before making a new release let's add Francois' app as a test case to prevent regressions. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Mon, Sep 4, 2017 at 10:39 PM, Tobias Soloschenko < tobiassolosche...@googlemail.com> wrote: > -1 also

Re: [VOTE] Release Apache Wicket 7.8.1

-1 also because of the Behavior bug. Good catch @François! kind regards Tobias > Am 04.09.2017 um 21:18 schrieb Andrea Del Bene : > > Sorry to bother you, but Francois Meillet has discovered a bug that might be > serious: WICKET-6462. In short, due to this bug >

Re: [VOTE] Release Apache Wicket 7.8.1

Sorry to bother you, but Francois Meillet has discovered a bug that might be serious: WICKET-6462. In short, due to this bug AjaxFormSubmitBehavior#onSubmit is called twice if its target form is removed during ajax request. Shall stop this release? I'm +1 to stop it as this bug might be quite

Re: [VOTE] Release Apache Wicket 7.8.1

+1 Built and poked some examples. Sven Am 01.09.2017 um 13:06 schrieb Emond Papegaaij: +1 Reviewed all code changed between 7.8.0 and 7.8.1 Emond On vrijdag 1 september 2017 11:37:22 CEST Martijn Dashorst wrote: +1 Martijn On Wed, Aug 30, 2017 at 9:34 PM, Andrea Del Bene

Re: [VOTE] Release Apache Wicket 7.8.1

+1 to release On Fri, Sep 1, 2017 at 1:06 PM, Emond Papegaaij wrote: > +1 > > Reviewed all code changed between 7.8.0 and 7.8.1 > > Emond > > On vrijdag 1 september 2017 11:37:22 CEST Martijn Dashorst wrote: > > +1 > > > > Martijn > > > > > > On Wed, Aug 30, 2017 at

Re: [VOTE] Release Apache Wicket 7.8.1

+1 Reviewed all code changed between 7.8.0 and 7.8.1 Emond On vrijdag 1 september 2017 11:37:22 CEST Martijn Dashorst wrote: > +1 > > Martijn > > > On Wed, Aug 30, 2017 at 9:34 PM, Andrea Del Bene > > wrote: > > This is a vote to release Apache Wicket 7.8.1 > > > >

Re: [VOTE] Release Apache Wicket 7.8.1

+1 Tested 1) signatures 2) build from sources 3) wicketstuff build 4) couple wicketstuff examples On Fri, Sep 1, 2017 at 4:37 PM, Martijn Dashorst wrote: > +1 > > Martijn > > > On Wed, Aug 30, 2017 at 9:34 PM, Andrea Del Bene > wrote: > >>

Re: [VOTE] Release Apache Wicket 7.8.1

On Wed, Aug 30, 2017 at 10:12 PM, Martijn Dashorst < martijn.dasho...@gmail.com> wrote: > I guess this is a release made of HEAD of 7.x. This would warrant a 7.9.0 > version rather than a 7.8.1. It also includes 2 fixes other than > WICKET-6457. Is this what we want? > > If we want a 7.8.1

Re: [VOTE] Release Apache Wicket 7.8.1

Good! :) On 31/08/2017 07:34, Martin Grigorov wrote: Hi, I agree with Maxim! There are only bugfixes so i is OK to be 6.8.1 Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Thu, Aug 31, 2017 at 6:49 AM, Maxim Solodovnik wrote: IMO

Re: [VOTE] Release Apache Wicket 7.8.1

Hi, I agree with Maxim! There are only bugfixes so i is OK to be 6.8.1 Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Thu, Aug 31, 2017 at 6:49 AM, Maxim Solodovnik wrote: > IMO it's not a problem to release 7.8.1 with 3 issues fixed >

Re: [VOTE] Release Apache Wicket 7.8.1

IMO it's not a problem to release 7.8.1 with 3 issues fixed They are fixed, so let's the new release has less issues :))) On Thu, Aug 31, 2017 at 4:05 AM, Andrea Del Bene wrote: > You are welcome! Yes, I've made it from wicket-7.x HEAD. Maybe you are > right, 7.8.1 should

Re: [VOTE] Release Apache Wicket 7.8.1

You are welcome! Yes, I've made it from wicket-7.x HEAD. Maybe you are right, 7.8.1 should contain only one or more specific fix. Feel free to invalidate the vote and role a new release. BTW, what shall be done in this case? Do we have to start from 7.8.0 release tag and then apply commits?

Re: [VOTE] Release Apache Wicket 7.8.1

Heya Andrea! Thanks for rolling the release! I would've done so tomorrow at work. I guess this is a release made of HEAD of 7.x. This would warrant a 7.9.0 version rather than a 7.8.1. It also includes 2 fixes other than WICKET-6457. Is this what we want? If we want a 7.8.1 release just with