Re: [vote] retry: release wicket 1.5-rc1

2011-01-21 Thread Igor Vaynberg
+1 to release -igor On Tue, Jan 18, 2011 at 10:16 AM, Igor Vaynberg igor.vaynb...@gmail.com wrote: this is the second vote to release wicket 1.5-rc1. all vote-blocking issues previously reported have been fixed branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC1

Re: [vote] retry: release wicket 1.5-rc1

2011-01-21 Thread Jeremy Thomerson
+1 to release On Fri, Jan 21, 2011 at 4:10 PM, Igor Vaynberg igor.vaynb...@gmail.comwrote: +1 to release -igor On Tue, Jan 18, 2011 at 10:16 AM, Igor Vaynberg igor.vaynb...@gmail.com wrote: this is the second vote to release wicket 1.5-rc1. all vote-blocking issues previously

Re: [vote] retry: release wicket 1.5-rc1

2011-01-21 Thread Igor Vaynberg
the voting is now closed. the vote has passed with 3 binding +1 and 2 nonbinding +1 thank you for voting. -igor On Fri, Jan 21, 2011 at 2:21 PM, Jeremy Thomerson jer...@wickettraining.com wrote: +1 to release On Fri, Jan 21, 2011 at 4:10 PM, Igor Vaynberg igor.vaynb...@gmail.comwrote: +1

Re: [vote] retry: release wicket 1.5-rc1

2011-01-21 Thread Eelco Hillenius
As far as I am concerned, that depends on this issue I just found: https://issues.apache.org/jira/browse/WICKET-3363. If that's just a problem with the example (probably the case, as the other localization examples work fine), I am +1 for releasing. If internationalization is broken, then I am -1.

Re: [vote] retry: release wicket 1.5-rc1

2011-01-21 Thread Igor Vaynberg
ault is the cut off DefaultMarkupSourcingStrategy -igor On Fri, Jan 21, 2011 at 2:52 PM, Eelco Hillenius eelco.hillen...@gmail.com wrote: As far as I am concerned, that depends on this issue I just found: https://issues.apache.org/jira/browse/WICKET-3363. If that's just a problem with the

Re: [vote] retry: release wicket 1.5-rc1

2011-01-21 Thread Eelco Hillenius
duh :-) On Fri, Jan 21, 2011 at 2:58 PM, Igor Vaynberg igor.vaynb...@gmail.com wrote: ault is the cut off DefaultMarkupSourcingStrategy -igor On Fri, Jan 21, 2011 at 2:52 PM, Eelco Hillenius eelco.hillen...@gmail.com wrote: As far as I am concerned, that depends on this issue I just found:

Re: [vote] retry: release wicket 1.5-rc1

2011-01-20 Thread Juergen Donnerstag
Findings (I can also create jira issues for all of them, just let me know): 1) based on Migration Guide 1.5, TabbedPanel improvement: 'ITab.getPanel() now returns WebMarkupContainerWithAssociatedMarkup instead of Panel so it is now possible to create tabs using Fragments or Panels rather then

Re: [vote] retry: release wicket 1.5-rc1

2011-01-20 Thread Martin Grigorov
On Thu, Jan 20, 2011 at 7:59 AM, Gabriel Bucher gabriel.buc...@gmail.comwrote: +1 (non-binding)... Findings (I can also create jira issues for all of them, just let me know): 1) based on Migration Guide 1.5, TabbedPanel improvement: 'ITab.getPanel() now returns

Re: [vote] retry: release wicket 1.5-rc1

2011-01-20 Thread Martin Grigorov
On Wed, Jan 19, 2011 at 8:04 PM, Martin Grigorov mgrigo...@apache.orgwrote: +1 Checked the quickstart, random wicket-examples. No major issues. Problems: - niceurl example doesn't load its css properly after some navigation at first load everything is ok but loading it later (after

Re: [vote] retry: release wicket 1.5-rc1

2011-01-20 Thread Igor Vaynberg
erm. we should be creating jira issues for these so we can seem them in the changelog. otherwise when we want to build rc2 it will look like there were no changes made. -igor On Thu, Jan 20, 2011 at 1:42 AM, Martin Grigorov mgrigo...@apache.org wrote: On Wed, Jan 19, 2011 at 8:04 PM, Martin

Re: [vote] retry: release wicket 1.5-rc1

2011-01-19 Thread Major Péter
I've clicked over my application and couldn't find any issue, so I'm (non-binding) +1. Regards, Peter 2011-01-18 19:16 keltezéssel, Igor Vaynberg írta: this is the second vote to release wicket 1.5-rc1. all vote-blocking issues previously reported have been fixed branch:

Re: [vote] retry: release wicket 1.5-rc1

2011-01-19 Thread Martin Grigorov
+1 Checked the quickstart, random wicket-examples. No major issues. Problems: - niceurl example doesn't load its css properly after some navigation at first load everything is ok but loading it later (after checking other apps) for some reason is broken reproduced with Chrome 10.x and

Re: [vote] retry: release wicket 1.5-rc1

2011-01-19 Thread Gabriel Bucher
+1 (non-binding)... Findings (I can also create jira issues for all of them, just let me know): 1) based on Migration Guide 1.5, TabbedPanel improvement: 'ITab.getPanel() now returns WebMarkupContainerWithAssociatedMarkup instead of Panel so it is now possible to create tabs using Fragments or

[vote] retry: release wicket 1.5-rc1

2011-01-18 Thread Igor Vaynberg
this is the second vote to release wicket 1.5-rc1. all vote-blocking issues previously reported have been fixed branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC1 artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC1/ maven repo: