Re: Eclipse formatting, was: Martin's wicket pull request

2014-01-31 Thread Martin Grigorov
http://blog.jetbrains.com/idea/2014/01/intellij-idea-13-importing-code-formatter-settings-from-eclipse/ Martin Grigorov Wicket Training and Consulting On Wed, Jan 29, 2014 at 10:42 AM, Sven Meier s...@meiers.net wrote: I've just recreated EclipseCodeFormat.xml from our old Eclipse's settings

Re: Eclipse formatting, was: Martin's wicket pull request

2014-01-29 Thread Sven Meier
I've just recreated EclipseCodeFormat.xml from our old Eclipse's settings (as I did already when I removed the settings from the repository). Result: When I reformat Application.java I get the same line breaks as Igor has reported. Additionally all comments are limited to 80 characters length

Re: Eclipse formatting, was: Martin's wicket pull request

2014-01-29 Thread Sven Meier
I've just recreated EclipseCodeFormat.xml from our old Eclipse's settings (as I did already when I removed the settings from the repository). Result: When I reformat Application.java I get the same line breaks as Igor has reported. Additionally all comments are limited to 80 characters length

Re: Eclipse formatting, was: Martin's wicket pull request

2014-01-28 Thread Igor Vaynberg
if the formatter config is correct i shouldnt have to just format edited lines... -igor On Tue, Jan 28, 2014 at 4:30 AM, Sven Meier s...@meiers.net wrote: Our format defines lineSplit=100, so that lines gets wrapped correctly. If you're using Eclipse's Save Actions, do you have format edited

Re: Eclipse formatting, was: Martin's wicket pull request

2014-01-28 Thread Sven Meier
if the formatter config is correct i shouldnt have to just format edited lines... Correct. It's just that we've coded with difference format settings / IDEs in the past years. To be sure we'd have to run the formatter once on all files. Sven On 01/28/2014 05:12 PM, Igor Vaynberg wrote:

Re: Eclipse formatting, was: Martin's wicket pull request

2013-11-14 Thread Martijn Dashorst
I did not realise this was waiting on me. I guess the main problem with using the resources bundle approach is that the formatting.xml remains necessary for compatibility with IntelliJ (and perhaps Netbeans). So we can't just bundle up the .settings folder and use that as the canonical version.

Re: Eclipse formatting, was: Martin's wicket pull request

2013-11-12 Thread Igor Vaynberg
any progress Martijn? -igor On Sun, Nov 10, 2013 at 12:49 AM, Martijn Dashorst martijn.dasho...@gmail.com wrote: We can let the eclipse plugin automatically add the project settings if we upload a jar to maven central with our configuration. plugin artifactIdmaven-eclipse-plugin/artifactId

Re: Eclipse formatting, was: Martin's wicket pull request

2013-11-11 Thread Martin Grigorov
I am OK with whatever is easy for Eclipse users (most of Wicket developers). I will update my IDEA formatting settings to match to yours. On Sun, Nov 10, 2013 at 10:49 AM, Martijn Dashorst martijn.dasho...@gmail.com wrote: We can let the eclipse plugin automatically add the project settings

Re: Eclipse formatting, was: Martin's wicket pull request

2013-11-09 Thread Martin Grigorov
But you have to import the xml just once, right ? It is not a big deal. Or the problem is that the xml messes up the other projects in your workspace ? On Sat, Nov 9, 2013 at 7:24 AM, Igor Vaynberg igor.vaynb...@gmail.comwrote: it is really frustrating that i have to do this manually now.

Re: Eclipse formatting, was: Martin's wicket pull request

2013-11-09 Thread Igor Vaynberg
yes, making it a workspace default messes up other projects... this way every time i import a project into the eclipse workspace i have to go and manually set the formatter on every module, which as you can imagine is not optimal -igor On Sat, Nov 9, 2013 at 1:40 PM, Martin Grigorov

Re: Eclipse formatting, was: Martin's wicket pull request

2013-11-08 Thread Martin Grigorov
I'll test this soon. I'll update the docs for IDEA too if needed. On Thu, Nov 7, 2013 at 11:02 AM, Sven Meier s...@meiers.net wrote: Thanks, I've added a hint to the Idea instructions. Regards Sven On 11/06/2013 10:12 AM, Vojtěch Krása wrote: You should also specify values for Class

Re: Eclipse formatting, was: Martin's wicket pull request

2013-11-08 Thread Igor Vaynberg
it is really frustrating that i have to do this manually now. before all i had to do was checkout the project and it was all set. wicket shares my workspace with other projects so the workspace-default is not going to work. can we drop the format def on wicket.apache.org and configure the maven

Re: Eclipse formatting, was: Martin's wicket pull request

2013-11-07 Thread Sven Meier
Thanks, I've added a hint to the Idea instructions. Regards Sven On 11/06/2013 10:12 AM, Vojtěch Krása wrote: You should also specify values for Class count to use import with '*' and Names count to use static import with '*', since these values are not in EclipseCodeFormat.xml, and differs

Eclipse formatting, was: Martin's wicket pull request

2013-11-06 Thread Sven Meier
Hi all, I removed all org.eclipse.jdt.[core|ui].prefs from the repo as discussed. EclipseCodeFormat.xml is updated now to our latest and greatest code format (which might differ between 6.x and master). Eclipse users should run mvn eclipse:eclipse to regenerate org.eclipse.jdt.core.prefs,

Re: Eclipse formatting, was: Martin's wicket pull request

2013-11-06 Thread Vojtěch Krása
You should also specify values for Class count to use import with '*' and Names count to use static import with '*', since these values are not in EclipseCodeFormat.xml, and differs between Idea and Eclipse by default. V. 2013/11/6 Sven Meier s...@meiers.net Hi all, I removed all