I've fixed the commit message, thanks for the feedback.
Emond
On Thu, Feb 6, 2020 at 1:05 PM Martin Grigorov wrote:
>
> Looks good!
>
> One nit: the commit message mentions twice
> 'should*Trigger*JavaScriptSubmitEvent'
> while the latter should be 'should*Invoke*JavaScriptFormOnsubmit'
> You
Looks good!
One nit: the commit message mentions twice
'should*Trigger*JavaScriptSubmitEvent'
while the latter should be 'should*Invoke*JavaScriptFormOnsubmit'
You can fix it in 'csp' branch before merging to master
On Wed, Feb 5, 2020 at 11:22 PM Emond Papegaaij
wrote:
> This is what I have
Fine by me.
Sven
On 05.02.20 22:22, Emond Papegaaij wrote:
This is what I have in mind:
https://github.com/apache/wicket/commit/b54938053a5bda2f4577966779d580e828f16e47
I think this is better than the old situation because this triggers
any submit handlers on the form (or any parent element
This is what I have in mind:
https://github.com/apache/wicket/commit/b54938053a5bda2f4577966779d580e828f16e47
I think this is better than the old situation because this triggers
any submit handlers on the form (or any parent element via bubbling)
not just the onsubmit attribute. It is a change in
On Wed, Feb 5, 2020 at 9:57 PM Emond Papegaaij
wrote:
> While fixing the CSP violations in the examples, I noticed a strange
> situation in SubmitLink example:
> http://examples8x.wicket.apache.org/compref/wicket/bookmarkable/org.apache.wicket.examples.compref.SubmitLinkPage
>
> In this example,
Hi,
While fixing the CSP violations in the examples, I noticed a strange
situation in SubmitLink example:
http://examples8x.wicket.apache.org/compref/wicket/bookmarkable/org.apache.wicket.examples.compref.SubmitLinkPage
In this example, the internal submit link immediately submits the
form,
