Re: Incorrect modification time in jars

2024-01-04 Thread Martin Grigorov
On Thu, Jan 4, 2024 at 1:02 PM Emond Papegaaij wrote: > > > > I've just opened a PR with this change ( > > https://github.com/apache/wicket/pull/758). I don't think this change > > will be problematic, but as it only really influences the release builds, > > it's hard to test its effect without

Re: Incorrect modification time in jars

2024-01-04 Thread Emond Papegaaij
> > I've just opened a PR with this change ( > https://github.com/apache/wicket/pull/758). I don't think this change > will be problematic, but as it only really influences the release builds, > it's hard to test its effect without doing an actual release. > It turned out that maven-bundle-plugin

Re: Incorrect modification time in jars

2024-01-04 Thread Emond Papegaaij
Op do 7 dec 2023 om 08:58 schreef Emond Papegaaij : > Op do 7 dec 2023 om 02:35 schreef Maxim Solodovnik : > >> File timestamps might be set to `project.build.outputTimestamp` by Maven >> This enables "reproducible builds" >> https://maven.apache.org/guides/mini/guide-reproducible-builds.html >>

Re: Incorrect modification time in jars

2023-12-07 Thread Emond Papegaaij
Op do 7 dec 2023 om 02:35 schreef Maxim Solodovnik : > File timestamps might be set to `project.build.outputTimestamp` by Maven > This enables "reproducible builds" > https://maven.apache.org/guides/mini/guide-reproducible-builds.html > > I believe Maven `project.build.outputTimestamp` property

Re: Incorrect modification time in jars

2023-12-06 Thread Maxim Solodovnik
File timestamps might be set to `project.build.outputTimestamp` by Maven This enables "reproducible builds" https://maven.apache.org/guides/mini/guide-reproducible-builds.html I believe Maven `project.build.outputTimestamp` property should be set in the pom.xml by release manager during release

Re: Incorrect modification time in jars

2023-12-06 Thread Emond Papegaaij
> > > > https://github.com/apache/wicket/blob/a68536eb095bb5cf59e4063b6af9436523ddc623/wicket-core/src/main/java/org/apache/wicket/settings/ResourceSettings.java#L650-L664 > LastModifiedResourceVersion is used in DEV mode by default. > MessageDigestResourceVersion is for PROD. > Yes, I know. I

Re: Incorrect modification time in jars

2023-12-06 Thread Martin Grigorov
On Wed, Dec 6, 2023 at 7:45 PM Emond Papegaaij wrote: > Op wo 6 dec 2023 18:22 schreef Richard Eckart de Castilho >: > > > > We can switch from LastModifiedResourceVersion to something else in our > > > applications to work around this issue, but maybe we should consider > > > tracking down

Re: Incorrect modification time in jars

2023-12-06 Thread Emond Papegaaij
Op wo 6 dec 2023 18:22 schreef Richard Eckart de Castilho : > > We can switch from LastModifiedResourceVersion to something else in our > > applications to work around this issue, but maybe we should consider > > tracking down this issue and release a 9.16.1. I'd expect we are not the > > only

Re: Incorrect modification time in jars

2023-12-06 Thread Richard Eckart de Castilho
Hi, > On 6. Dec 2023, at 16:48, Emond Papegaaij wrote: > > We can switch from LastModifiedResourceVersion to something else in our > applications to work around this issue, but maybe we should consider > tracking down this issue and release a 9.16.1. I'd expect we are not the > only ones using

Incorrect modification time in jars

2023-12-06 Thread Emond Papegaaij
Hi, With the upgrade to wicket 9.16.0 we've seen some issues with the new 'Wicket.Event.requestSubmit' method that was added to wicket-ajax-jquery. It turns out that a cached version of the resource was used, and this seems to be caused by an incorrect version string in the url. The filename is