Re: JDK 16 is in Rampdown Phase One

2020-12-15 Thread Martin Grigorov
On Tue, Dec 15, 2020 at 9:49 AM Maxim Solodovnik wrote: > On Tue, 15 Dec 2020 at 14:45, Martin Grigorov > wrote: > > > Hi Chris, > > > > Thank you for your advices! > > > > On Mon, Dec 14, 2020 at 6:11 PM Chris Hegarty > > wrote: > > > > > > > > > On 14 Dec 2020, at 10:03, Rory O'Donnell > >

Re: JDK 16 is in Rampdown Phase One

2020-12-15 Thread Martin Grigorov
On Tue, Dec 15, 2020 at 10:09 AM Emond Papegaaij wrote: > Hi, > > Before we go that way, please do some performance tests. We've seen > This code is used as a fallback when the class cannot be found in the webapp class loader. I.e. very rarely. > very bad performance in StackWalker,

Re: JDK 16 is in Rampdown Phase One

2020-12-15 Thread Emond Papegaaij
Hi, Before we go that way, please do some performance tests. We've seen very bad performance in StackWalker, especially when it is called many times over. This may have improved in more recent JDKs, but in Java 11 the overhead was so significant that a single StackWalker call in a log call would

Re: JDK 16 is in Rampdown Phase One

2020-12-14 Thread Maxim Solodovnik
On Tue, 15 Dec 2020 at 14:45, Martin Grigorov wrote: > Hi Chris, > > Thank you for your advices! > > On Mon, Dec 14, 2020 at 6:11 PM Chris Hegarty > wrote: > > > > > > On 14 Dec 2020, at 10:03, Rory O'Donnell > > wrote: > > > > > > ... > > > On 14/12/2020 09:45, Martin Grigorov wrote: > > >>

Re: JDK 16 is in Rampdown Phase One

2020-12-14 Thread Martin Grigorov
Hi Chris, Thank you for your advices! On Mon, Dec 14, 2020 at 6:11 PM Chris Hegarty wrote: > > > On 14 Dec 2020, at 10:03, Rory O'Donnell > wrote: > > > > ... > > On 14/12/2020 09:45, Martin Grigorov wrote: > >> Hi Rory, > >> > >> Apache Wicket build and tests are OK with JDK 16 b28 for both

Re: JDK 16 is in Rampdown Phase One

2020-12-14 Thread Chris Hegarty
> On 14 Dec 2020, at 10:03, Rory O'Donnell wrote: > > ... > On 14/12/2020 09:45, Martin Grigorov wrote: >> Hi Rory, >> >> Apache Wicket build and tests are OK with JDK 16 b28 for both aarch64 and >> x86_64 (Ubuntu 20.10)! >> >> I had to add --add-opens=java.base/java.io=ALL-UNNAMED to >>

Re: JDK 16 is in Rampdown Phase One

2020-12-14 Thread Rory O'Donnell
Thanks for the update Martin! On 14/12/2020 09:45, Martin Grigorov wrote: Hi Rory, Apache Wicket build and tests are OK with JDK 16 b28 for both aarch64 and x86_64 (Ubuntu 20.10)! I had to add --add-opens=java.base/java.io=ALL-UNNAMED to maven-surefire-plugin's JVM arguments because it seems

Re: JDK 16 is in Rampdown Phase One

2020-12-14 Thread Martin Grigorov
Hi Rory, Apache Wicket build and tests are OK with JDK 16 b28 for both aarch64 and x86_64 (Ubuntu 20.10)! I had to add --add-opens=java.base/java.io=ALL-UNNAMED to maven-surefire-plugin's JVM arguments because it seems this plugin does not use the (automatic) module name of the Maven project and

Re: JDK 16 is in Rampdown Phase One

2020-12-14 Thread Rory O'Donnell
Thanks Martin! On 14/12/2020 07:46, Martin Grigorov wrote: Hi Rory, Unfortunately this build breaks Wicket's usage of Serialization API. public void writeObject(Object streamObj) is not called for some reason and Wicket cannot intercept the calls. I will investigate further and update you

Re: JDK 16 is in Rampdown Phase One

2020-12-13 Thread Martin Grigorov
Hi Rory, Unfortunately this build breaks Wicket's usage of Serialization API. public void writeObject(Object streamObj) is not called for some reason and Wicket cannot intercept the calls. I will investigate further and update you once I have more details. Martin On Sun, Dec 13, 2020 at 6:39 PM

JDK 16 is in Rampdown Phase One

2020-12-13 Thread Rory O'Donnell
Hi Martin, *Per the JDK 16 schedule , we are in Rampdown Phase One* *[1] . * *Please advise if you find any issues while testing the latest Early Access builds.* * Schedule for JDK 16 o *2020/12/10 Rampdown Phase One* o 2021/01/14  Rampdown Phase Two o 2021/02/04  Initial