Re: wicket-ajax.js cleanup

2019-05-07 Thread Martin Grigorov
On Tue, May 7, 2019 at 2:19 PM Andrew Kondratev wrote: > What I currently set up is that it only rebuilds the wicket-ajax when > appropriate profile is enabled. You will run into a problem only if you > need to modify the wicket-ajax. If you really have to do that and you are > in such hostile

Re: wicket-ajax.js cleanup

2019-05-07 Thread Andrew Kondratev
What I currently set up is that it only rebuilds the wicket-ajax when appropriate profile is enabled. You will run into a problem only if you need to modify the wicket-ajax. If you really have to do that and you are in such hostile environment as you describe then you can always use your local

Re: wicket-ajax.js cleanup

2019-05-07 Thread Sven Meier
Hi Martin, every company I've worked for uses its internal Nexus as a pull-through cache. First thing the frontend plugin is doing? Downloading an exe file from the webz :( Sven > > On 07.05.2019 at 12:12,wrote: > > > On Mon, May 6, 2019 at 12:54 PM

Re: wicket-ajax.js cleanup

2019-05-07 Thread Martin Grigorov
On Mon, May 6, 2019 at 12:54 PM Sven Meier wrote: > > > Sure, but often enough a corporate web proxy/virus scanner will make this > a real pain :( > Isn't the same valid for Maven dependencies? If you cannot reach Maven Central then you won't be able to build the Java classes. > > > > Sven >

Re: wicket-ajax.js cleanup

2019-05-06 Thread Sven Meier
Sure, but often enough a corporate web proxy/virus scanner will make this a real pain :( Sven > > On 05.05.2019 at 20:02,wrote: > > > On vrijdag 3 mei 2019 17:16:02 CEST Sven Meier wrote: > JS Tests are not > built each time, so npm is not a requirement to

Re: wicket-ajax.js cleanup

2019-05-05 Thread Andrew Kondratev
The package-lock.json could be git ignored if changes in the dependencies tree do not matter a lot. It exists mostly for convenience, to help developers know if something has changed in dependencies. пн, 6 мая 2019 г. в 08:56, Emond Papegaaij : > On vrijdag 3 mei 2019 17:16:02 CEST Sven Meier

Re: wicket-ajax.js cleanup

2019-05-05 Thread Emond Papegaaij
On vrijdag 3 mei 2019 17:16:02 CEST Sven Meier wrote: > JS Tests are not built each time, so npm is not a requirement to build > Wicket. I'd like to keep it that way. With the frontend-maven-plugin it isn't required to have it installed on your system. The plugin will download node and npm as

Re: wicket-ajax.js cleanup

2019-05-03 Thread Sven Meier
JS Tests are not built each time, so npm is not a requirement to build Wicket. I'd like to keep it that way. Sven > > On 03.05.2019 at 16:52,wrote: > > > Right. There is not issue with build then. сб, 4 мая 2019 г. в 00:39, Martin > Grigorov :

Re: wicket-ajax.js cleanup

2019-05-03 Thread Andrew Kondratev
Right. There is not issue with build then. сб, 4 мая 2019 г. в 00:39, Martin Grigorov : > On Fri, May 3, 2019, 15:36 Emond Papegaaij > wrote: > > > Hi, > > > > We use the frontend-maven-plugin, which automatically downloads and > > installs > > node as part of your maven build. It works quite

Re: wicket-ajax.js cleanup

2019-05-03 Thread Martin Grigorov
On Fri, May 3, 2019, 15:36 Emond Papegaaij wrote: > Hi, > > We use the frontend-maven-plugin, which automatically downloads and > installs > node as part of your maven build. It works quite ok. > This is what Wicket JS tests uses as well. > Emond > > On vrijdag 3 mei 2019 11:56:14 CEST Andrew

Re: wicket-ajax.js cleanup

2019-05-03 Thread Emond Papegaaij
Hi, We use the frontend-maven-plugin, which automatically downloads and installs node as part of your maven build. It works quite ok. Emond On vrijdag 3 mei 2019 11:56:14 CEST Andrew Kondratev wrote: > Thank you. I understand these concerns. > > Speaking about performance concern, if node is

Re: wicket-ajax.js cleanup

2019-05-03 Thread Andrew Kondratev
Thank you. I understand these concerns. Speaking about performance concern, if node is available on machine and modules are installed it takes less than 3 seconds to build on my laptop from 2013, incomparable with entire wicket build time. However, with node installation and modules installation

Re: wicket-ajax.js cleanup

2019-05-03 Thread Martin Grigorov
On Fri, May 3, 2019 at 9:32 AM Sven Meier wrote: > > > Hi, > > > > yes, we could get rid of some crufty code here. > > > > But before you put too much effort into this: > > Do we really want to blow up our build with npm/typescript just to > generate ~3000 lines of code? > > I doubt that it's

Re: wicket-ajax.js cleanup

2019-05-03 Thread Sven Meier
Hi, yes, we could get rid of some crufty code here. But before you put too much effort into this: Do we really want to blow up our build with npm/typescript just to generate ~3000 lines of code? I doubt that it's worth it. The code is very stable and well tested anyway.

Re: wicket-ajax.js cleanup

2019-05-02 Thread Andrew Kondratev
Hi Sven! Do you mean removing entire wicket-ajax-jquery-debug.js and making Wicket.Log to simply use console instead? пт, 3 мая 2019 г. в 01:16, Andrea Del Bene : > I'm +1 for all these proposed improvements. > > On 5/2/19 11:55 AM, Sven Meier wrote: > > > > > > Indeed (stupid phones), see my

Re: wicket-ajax.js cleanup

2019-05-02 Thread Andrea Del Bene
I'm +1 for all these proposed improvements. On 5/2/19 11:55 AM, Sven Meier wrote: Indeed (stupid phones), see my follow up. Thanks Sven On 02.05.2019 at 11:53,wrote: Hi Sven, I have the feeling you pressed the Send button before finishing

Re: wicket-ajax.js cleanup

2019-05-02 Thread Sven Meier
Indeed (stupid phones), see my follow up. Thanks Sven > > On 02.05.2019 at 11:53,wrote: > > > Hi Sven, I have the feeling you pressed the Send button before finishing > your email. On Thu, May 2, 2019 at 12:42 PM Sven Meier wrote: > > > Hi > all, >

Re: wicket-ajax.js cleanup

2019-05-02 Thread Martin Grigorov
On Thu, May 2, 2019 at 12:53 PM Sven Meier wrote: > > > (sorry wasn't finished) > > > > Before starting any larger effort on our JS Code, we could do some smaller > cleanup, for example; > > > > 1) remove Ajax debug mode > > 2) move "flexible drag support" from wicket-ajax to modal window > +1

Re: wicket-ajax.js cleanup

2019-05-02 Thread Martin Grigorov
Hi Sven, I have the feeling you pressed the Send button before finishing your email. On Thu, May 2, 2019 at 12:42 PM Sven Meier wrote: > > > Hi all, > > > > before starting a larger effort on our JS code, we could do some smaller > cleanups. > > > > - remove Ajax debug mode > Last time when I

Re: wicket-ajax.js cleanup

2019-05-02 Thread Sven Meier
(sorry wasn't finished) Before starting any larger effort on our JS Code, we could do some smaller cleanup, for example; 1) remove Ajax debug mode 2) move "flexible drag support" from wicket-ajax to modal window 1) has been suggested before, but apparently some poeple still

wicket-ajax.js cleanup

2019-05-02 Thread Sven Meier
Hi all, before starting a larger effort on our JS code, we could do some smaller cleanups. - remove Ajax debug mode