Re: git commit: WICKET-4932: fixing callback url expectations in bookmarkable pages

2013-01-10 Thread Martin Grigorov
Yes, this change in the produced HTML is needed to be able to recreate a page. One question: will the link still be ?x (without className in front) if the setting is 'false' ? On Wed, Jan 9, 2013 at 11:24 PM, pe...@apache.org wrote: Updated Branches:

Re: git commit: WICKET-4932: testing if the page is bookmarkable before to encode the callback url for a component inside it

2013-01-10 Thread Martin Grigorov
On Thu, Jan 10, 2013 at 12:58 AM, pe...@apache.org wrote: Updated Branches: refs/heads/sandbox/bookmarkable-callback-url fba8bddd9 - 1ec0b8b36 WICKET-4932: testing if the page is bookmarkable before to encode the callback url for a component inside it Project:

Re: git commit: WICKET-4932: testing if the page is bookmarkable before to encode the callback url for a component inside it

2013-01-10 Thread Pedro Santos
Wow, thx, found other typo in the commentary article as well, should be ok now. Yep, I would rather to keep both as public. We need BookmarkablePage with a public constructor receiving a PageParameters or no parameters in order to be tested as bookmarkable. The majority of pages we have in the