Re: Please review WICKET-983: Merge the portlet support branch into the trunk

2007-09-20 Thread Frank Bille
I think we should wrap this up and hold a vote on how to proceed with portlets. As I see it there are two options: 1) Merge portlets into trunk now and delay the final 1.3 release until the dust has settled. 2) Delay portlets support until 1.4. WDYT? Frank On 9/19/07, Gwyn Evans [EMAIL

Re: Please review WICKET-983: Merge the portlet support branch into the trunk

2007-09-20 Thread Ate Douma
Gwyn Evans wrote: On Wednesday, September 19, 2007, 12:12:16 AM, Ate [EMAIL PROTECTED] wrote: Since -beta3, there have been several other commits to the trunk which also affect critical areas like url handling: should those not have been applied either? Probably not! :-) The amount of

Re: Please review WICKET-983: Merge the portlet support branch into the trunk

2007-09-20 Thread Gwyn Evans
Yes, it's about time, I think... ...Done. /Gwyn On Thursday, September 20, 2007, 10:28:05 AM, Frank [EMAIL PROTECTED] wrote: I think we should wrap this up and hold a vote on how to proceed with portlets. As I see it there are two options: 1) Merge portlets into trunk now and delay

Re: [VOTE] WICKET-983: Merging portlet support

2007-09-20 Thread Gwyn Evans
On Thursday, September 20, 2007, 11:09:04 AM, Gwyn [EMAIL PROTECTED] wrote: [X] 1) Merge now and accept the (small but non-zero) chance of delaying 1.3 a bit. /Gwyn

Re: [VOTE] WICKET-983: Merging portlet support

2007-09-20 Thread Ate Douma
Gwyn Evans wrote: We should have a vote on https://issues.apache.org/jira/browse/WICKET-983 (Merge the portlet support branch into the trunk) to decide whether we want this in core now or later. Choices: [X] 1) Merge now and accept the (small but non-zero) chance of delaying

Re: [VOTE] WICKET-983: Merging portlet support

2007-09-20 Thread Wander Grevink
I'm going to need this, so here's my non-binding vote for what it's worth [X] 1) Merge now and accept the (small but non-zero) chance of delaying 1.3 a bit.

Re: Please review WICKET-983: Merge the portlet support branch into the trunk

2007-09-20 Thread Ate Douma
Frank Bille wrote: I think we should wrap this up and hold a vote on how to proceed with portlets. As I see it there are two options: 1) Merge portlets into trunk now and delay the final 1.3 release until the dust has settled. 2) Delay portlets support until 1.4. WDYT? +1 from me, but I'm not

Re: [VOTE] WICKET-983: Merging portlet support

2007-09-20 Thread Ate Douma
Martijn Dashorst wrote: I would feel more confident in the outcome when Al has had his looksy on sunday. Shall we at least extend the vote until then? Fine by me, +1 Ate Typical votes run for 72 hours, so it wouldn't delay too much if we extend it until sunday evening or so. If Al hasn't

Re: Please review WICKET-983: Merge the portlet support branch into the trunk

2007-09-20 Thread Frank Bille
On 9/20/07, Ate Douma [EMAIL PROTECTED] wrote: Frank Bille wrote: I think we should wrap this up and hold a vote on how to proceed with portlets. As I see it there are two options: 1) Merge portlets into trunk now and delay the final 1.3 release until the dust has settled. 2) Delay

Re: [VOTE] WICKET-983: Merging portlet support

2007-09-20 Thread Gwyn Evans
On Thursday, September 20, 2007, 11:28:02 AM, Martijn [EMAIL PROTECTED] wrote: I would feel more confident in the outcome when Al has had his looksy on sunday. Shall we at least extend the vote until then? Typical votes run for 72 hours, so it wouldn't delay too much if we extend it until

Re: [VOTE] WICKET-983: Merging portlet support

2007-09-20 Thread Al Maw
Gwyn Evans wrote: On Thursday, September 20, 2007, 11:28:02 AM, Martijn [EMAIL PROTECTED] wrote: I would feel more confident in the outcome when Al has had his looksy on sunday. Shall we at least extend the vote until then? Typical votes run for 72 hours, so it wouldn't delay too much if we

is the key of buffered response too simplistic?

2007-09-20 Thread Eelco Hillenius
I just came across this in WicketFilter: BufferedHttpServletResponse bufferedResponse = null; String queryString = servletRequest.getQueryString(); if (!Strings.isEmpty(queryString)) { bufferedResponse = webApplication.popBufferedResponse(sessionId,

Re: remove jwebunit dependency for examples

2007-09-20 Thread Martijn Dashorst
On 9/9/07, Gwyn Evans [EMAIL PROTECTED] wrote: Commit details look to be as follow (not that the URL works,) but I don't see any mention of it on the mailing lists... Revision: 600 http://svn.sourceforge.net/jwebunit/?rev=600view=rev Author: henryju Date: 2006-11-07 02:22:35 -0800 (Tue, 07

Re: svn commit: r577576 - /wicket/trunk/README

2007-09-20 Thread Martijn Dashorst
I appreciate the effort but we are very much better off if we could include the generated dependencies reports of maven. This readme document will get stale and out of date. And when building a release you really don't have the time to parse and verify the readme document for libraries. maven

Re: svn commit: r577576 - /wicket/trunk/README

2007-09-20 Thread Eelco Hillenius
On 9/20/07, Martijn Dashorst [EMAIL PROTECTED] wrote: I appreciate the effort but we are very much better off if we could include the generated dependencies reports of maven. This readme document will get stale and out of date. And when building a release you really don't have the time to

Re: mvn site: a possible solution

2007-09-20 Thread Tim O'Brien
BTW, I'm continuing to run the full javadoc build in ~tobrien as an interim solution. It certainly isn't ideal, but it's one way to solve the problem. :-) I'll keep an eye on the discussion. On 9/10/07, Gerolf Seitz [EMAIL PROTECTED] wrote: issue filed:

Re: mvn site: a possible solution

2007-09-20 Thread Gwyn Evans
On Thursday, September 20, 2007, 11:13:23 PM, Tim [EMAIL PROTECTED] wrote: BTW, I'm continuing to run the full javadoc build in ~tobrien as an interim solution. It certainly isn't ideal, but it's one way to solve the problem. I'll keep an eye on the discussion. Please flag it (to