Re: Remove Classes#isPrimitive

2007-09-22 Thread Eelco Hillenius
On 9/21/07, Igor Vaynberg [EMAIL PROTECTED] wrote: have you looked at the code? Classes.isprimitive does not differentiate between int and Integer, while Class.isprimitive() does I overlooked that, but frankly, the name is ill chosen (as you're *not* just testing whether the argument is a

Re: Remove Classes#isPrimitive

2007-09-22 Thread Igor Vaynberg
so remove it and paste its body wherever it is used. -igor On 9/21/07, Eelco Hillenius [EMAIL PROTECTED] wrote: On 9/21/07, Igor Vaynberg [EMAIL PROTECTED] wrote: have you looked at the code? Classes.isprimitive does not differentiate between int and Integer, while

Re: Remove Classes#isPrimitive

2007-09-22 Thread Eelco Hillenius
On 9/21/07, Igor Vaynberg [EMAIL PROTECTED] wrote: so remove it and paste its body wherever it is used. Done. Eelco

Re: possible NPE in DefaultMarkupCacheKeyProvider?

2007-09-22 Thread Juergen Donnerstag
you are right. I fixed it. getCacheKey is now called with containerClass.. Thanks Juergen On 9/20/07, Xavier Hanin [EMAIL PROTECTED] wrote: Hi, I've noticed something strange in the code of MarkupCache and DefaultMarkupCacheKeyProvider. In MarkupCache#getMarkup there is a verification that