Re: remove oninitialize/onconfigure from 1.4.x?

2010-07-24 Thread Martin Grigorov
+1 for vote in users@ I just found a problem while creating new wicket-example for the new request mappers: java.lang.StackOverflowError at org.apache.wicket.MarkupContainer.addedComponent(MarkupContainer.java:978) at org.apache.wicket.MarkupContainer.add(MarkupContainer.java:168) at

Re: remove oninitialize/onconfigure from 1.4.x?

2010-07-24 Thread Johan Compagner
I think that fix should be fine The thing i have is why does Page.componentAdded() really call initialize again Will that not happen anyway? Also now i do see a but of weird initializing when you see the order.. In MarkupContainer.addedComponent: if (page != null)

Re: remove oninitialize/onconfigure from 1.4.x?

2010-07-24 Thread Martijn Dashorst
Given these nuances, and the binary incompatibilty, shouldn't we just revert for 1.4.x and ensure proper working in 1.5? It's not that folks are unable to create awesome apps with 1.4 without these changes. I'd rather not introduce subtle bugs into 1.4.x at this stage. Martijn On Sat, Jul 24,

Re: remove oninitialize/onconfigure from 1.4.x?

2010-07-24 Thread Igor Vaynberg
On Sat, Jul 24, 2010 at 2:19 AM, Johan Compagner jcompag...@gmail.com wrote: I think that fix should be fine The thing i have is why does Page.componentAdded() really call initialize again its called because the page object itself needs to have onInitialize() called on it. -igor Will that

Re: remove oninitialize/onconfigure from 1.4.x?

2010-07-24 Thread Igor Vaynberg
recrete it in ComponentInitializationTest and fix it :) -igor On Sat, Jul 24, 2010 at 2:05 AM, Martin Grigorov mgrigo...@apache.org wrote: +1 for vote in users@ I just found a problem while creating new wicket-example for the new request mappers: java.lang.StackOverflowError  at

Examples for the new request mappers

2010-07-24 Thread Martin Grigorov
Hi, I just added a new wicket-examples application (Wicket 1.5 only) showing two custom request mappers: * custom home page - e.g. requesting http://example.com will load Application#getHomePage() at http://example.com/custom/path * locale first mapper - the session locale is encoded as first

Re: Examples for the new request mappers

2010-07-24 Thread Martin Makundi
Hi M! Is was there a tutorial on this topic? ** Martin 2010/7/24 Martin Grigorov mgrigo...@apache.org: Hi, I just added a new wicket-examples application (Wicket 1.5 only) showing two custom request mappers: * custom home page - e.g. requesting http://example.com will load

Re: Examples for the new request mappers

2010-07-24 Thread Martin Grigorov
For now the only tutorial is the source code :-/ On Sat, Jul 24, 2010 at 8:47 PM, Martin Makundi martin.maku...@koodaripalvelut.com wrote: Hi M! Is was there a tutorial on this topic? ** Martin 2010/7/24 Martin Grigorov mgrigo...@apache.org: Hi, I just added a new wicket-examples

Re: Examples for the new request mappers

2010-07-24 Thread Martin Makundi
Any brief what this is all about ;) ? Sounds interesting but I don't have any clue. Any selected links to previous discussion on the topic? ** Martin 2010/7/24 Martin Grigorov mgrigo...@apache.org: For now the only tutorial is the source code :-/ On Sat, Jul 24, 2010 at 8:47 PM, Martin