Re: Method chaining

2014-02-02 Thread Martin Grigorov
A place where method chaining would be good to have is in all XyzSettings classes. Martin Grigorov Wicket Training and Consulting On Fri, Jan 31, 2014 at 4:45 PM, Nick Pratt nbpr...@gmail.com wrote: Just to be clear - I'm not arguing against the concept of method chaining because of some

Method chaining

2014-01-31 Thread Martin Grigorov
Hi, What others think about https://issues.apache.org/jira/browse/WICKET-5459 ? Should Wicket use return this pattern where makes sense instead of 'void' return type ? One problem that I see is with: MyPage.doSomething() will/may return some base type of MyPage. I remember some trink for Java to

Re: Method chaining

2014-01-31 Thread Maxim Solodovnik
I personally like chaining in Wicket On Fri, Jan 31, 2014 at 9:08 PM, Martin Grigorov mgrigo...@apache.orgwrote: Hi, What others think about https://issues.apache.org/jira/browse/WICKET-5459? Should Wicket use return this pattern where makes sense instead of 'void' return type ? One

Re: Method chaining

2014-01-31 Thread Rob Audenaerde
I like chaining for instances. I don't see much use for chaining in static methods. On Fri, Jan 31, 2014 at 3:12 PM, Maxim Solodovnik solomax...@gmail.comwrote: I personally like chaining in Wicket On Fri, Jan 31, 2014 at 9:08 PM, Martin Grigorov mgrigo...@apache.org wrote: Hi, What

Re: Method chaining

2014-01-31 Thread Sven Meier
I don't think it makes sense here: In all of Wicket's code there's a single place only, where two metaData entries are set consecutively. Sven On 01/31/2014 03:08 PM, Martin Grigorov wrote: Hi, What others think about https://issues.apache.org/jira/browse/WICKET-5459 ? Should Wicket use

Re: Method chaining

2014-01-31 Thread Martin Grigorov
I ask generally, not just about #setMetaData(). For example: someComponent.add(behavior).add(child).setVisible(false).setEnabled(false).setMetaData(..) ... And not just about Component class but everywhere where it makes sense. Martin Grigorov Wicket Training and Consulting On Fri, Jan 31, 2014

Re: Method chaining

2014-01-31 Thread Martin Makundi
Java should natively chain all void instance methods... ** Martin 2014-01-31 Sven Meier s...@meiers.net I don't think it makes sense here: In all of Wicket's code there's a single place only, where two metaData entries are set consecutively. Sven On 01/31/2014 03:08 PM, Martin Grigorov

Re: Method chaining

2014-01-31 Thread Nick Pratt
Which would be perfectly fine if the JVM told you which specific method invocation on a source code line with chained methods threw an exception. While you can sometimes figure it out, you can't always, and an answer of if it happens again, we'll know how to fix it just doesn't fly in certain

Re: Method chaining

2014-01-31 Thread Martin Grigorov
code. Nothing stops you to do: instance.abc(); instance.def() in one line! No method chaining here but again hard to find which method blowed ... N On Fri, Jan 31, 2014 at 9:32 AM, Martin Makundi martin.maku...@koodaripalvelut.com wrote: Java should natively chain all void instance

Re: Method chaining

2014-01-31 Thread tetsuo
Making 'void' methods return 'this' doesn't prevent you to write each call in a new line. But gives others the choice to call it inline. It could be a problem if Wicket's internal code used chaining extensively, but I find it very convenient to chain calls, specially when building the component

Re: Method chaining

2014-01-31 Thread Nick Pratt
Just to be clear - I'm not arguing against the concept of method chaining because of some stylistic / personal preference point, but from a practical production diagnostic point, when you need to be able to definitively fix the problem once, and once only. Pushing a temporary release out