To elaborate: it is now part of 1.3, the book and about 1000 web applications.
Martijn
On 11/1/07, Martijn Dashorst [EMAIL PROTECTED] wrote:
No
Martijn
On 11/1/07, Bruno Borges [EMAIL PROTECTED] wrote:
isn't this a reason to start with that talk again Igor, about replacing
setRequired
how would a validator work better here then a boolean?
-igor
On 11/1/07, Bruno Borges [EMAIL PROTECTED] wrote:
isn't this a reason to start with that talk again Igor, about replacing
setRequired with an IValidator?
regards,
bruno
Igor Vaynberg wrote:
On 8/13/07, Eelco Hillenius [EMAIL
we had that and we changed it to a boolean because required is a thing
that must be validated before converters and other validators
On 11/1/07, Bruno Borges [EMAIL PROTECTED] wrote:
isn't this a reason to start with that talk again Igor, about replacing
setRequired with an IValidator?
Ok, one more reply then.
But for DateTimePanel for instance, the check should pass if there is any
input for the date text field; the time- and AM/PM fields can be ignored.
great, so datefield { isrequired() { return fcp.isrequired()}}, the other
fields are simply not required. everything
On 8/12/07, Eelco Hillenius [EMAIL PROTECTED] wrote:
Ok, one more reply then.
But for DateTimePanel for instance, the check should pass if there is
any
input for the date text field; the time- and AM/PM fields can be
ignored.
great, so datefield { isrequired() { return
hrm, so lets see DateTimeField:
public final boolean isRequired()
{
// prevent clients from overriding
return super.isRequired();
}
public FormComponent setRequired(boolean required)
{
dateField.setRequired(required);
return this;
}
On 8/13/07, Eelco Hillenius [EMAIL PROTECTED] wrote:
On 8/13/07, Eelco Hillenius [EMAIL PROTECTED] wrote:
isnt this broken? isrequired() doesnt return the same value as
setrequired().
You you're right, this would be it:
so if you made this mistake imagine everyone else making it!
You are just nitpicking. 99.9% of people won't override setRequired to
start with.
i dont know about that. seems to me that the majority of people who
implement a FormComponentPanel will be forced to overwrite it since that is
currently the model you have put in place.
Yeah, they should,
