Re: wicket git commit: better test dependencies defaults as in wicket 7 and 8 plus changing wicket-core hamcrest dependency scope to test

[Pedro Santos]

Hi Martin,

Indeed, thx. Just removed the duplicated dependencies. I noticed that we
have a few more redundant scopes across 6.x, 7.x and master branches; will
run a larger cleanup later so we can have a meaningful setup inside
.

Pedro Santos

On Tue, Sep 6, 2016 at 5:02 AM, Martin Grigorov 
wrote:

> Hi Pedro,
>
> On Tue, Sep 6, 2016 at 12:11 AM,  wrote:
>
>> Repository: wicket
>> Updated Branches:
>>   refs/heads/wicket-6.x 5d5af682d -> 635b21c6e
>>
>>
>> better test dependencies defaults as in wicket 7 and 8 plus changing
>> wicket-core hamcrest dependency scope to test
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/635b21c6
>> Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/635b21c6
>> Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/635b21c6
>>
>> Branch: refs/heads/wicket-6.x
>> Commit: 635b21c6e2c2862f9fc196e4af653bb209c06b36
>> Parents: 5d5af68
>> Author: Pedro Henrique Oliveira dos Santos 
>> Authored: Mon Sep 5 19:11:31 2016 -0300
>> Committer: Pedro Henrique Oliveira dos Santos 
>> Committed: Mon Sep 5 19:11:31 2016 -0300
>>
>> --
>>  pom.xml | 20 
>>  wicket-core/pom.xml | 16 
>>  wicket-util/pom.xml |  4 
>>  3 files changed, 20 insertions(+), 20 deletions(-)
>> --
>>
>>
>> http://git-wip-us.apache.org/repos/asf/wicket/blob/635b21c6/pom.xml
>> --
>> diff --git a/pom.xml b/pom.xml
>> index c20552c..c104886 100644
>> --- a/pom.xml
>> +++ b/pom.xml
>> @@ -523,6 +523,26 @@
>> test
>> 
>> 
>> +   org.hamcrest
>> +   hamcrest-library
>> +   test
>> +   
>> +   
>> +   org.hamcrest
>> +   hamcrest-core
>> +   test
>> +   
>> +   
>> +   org.hamcrest
>> +   hamcrest-library
>> +   test
>> +   
>> +   
>> +   org.hamcrest
>> +   hamcrest-core
>> +   test
>> +   
>>
>
> Those new entries look duplicated to me.
> If they are in  section then they don't need the 
> setting. It comes from .
>
>
>> +   
>> org.mockito
>> mockito-all
>> test
>>
>> http://git-wip-us.apache.org/repos/asf/wicket/blob/635b21c6/
>> wicket-core/pom.xml
>> --
>> diff --git a/wicket-core/pom.xml b/wicket-core/pom.xml
>> index 06c5dd2..7689a14 100644
>> --- a/wicket-core/pom.xml
>> +++ b/wicket-core/pom.xml
>> @@ -50,22 +50,6 @@
>> provided
>> 
>> 
>> -   
>> -   org.mockito
>> -   mockito-all
>> -   provided
>> -   
>> -   
>> -   
>> -   org.hamcrest
>> -   hamcrest-library
>> -   provided
>> -   
>> -   
>> -   org.hamcrest
>> -   hamcrest-core
>> -   provided
>> -   
>> 
>> 
>> 
>>
>> http://git-wip-us.apache.org/repos/asf/wicket/blob/635b21c6/
>> wicket-util/pom.xml
>> --
>> diff --git a/wicket-util/pom.xml b/wicket-util/pom.xml
>> index 0da1693..edd0bb9 100755
>> --- a/wicket-util/pom.xml
>> +++ b/wicket-util/pom.xml
>> @@ -31,10 +31,6 @@
>> junit
>> provided
>> 
>> -   
>> -   org.hamcrest
>> -   hamcrest-library
>> -   
>>
>>
>> 
>>
>>
>

Re: wicket git commit: better test dependencies defaults as in wicket 7 and 8 plus changing wicket-core hamcrest dependency scope to test

[Martin Grigorov]

Hi Pedro,

On Tue, Sep 6, 2016 at 12:11 AM,  wrote:

> Repository: wicket
> Updated Branches:
>   refs/heads/wicket-6.x 5d5af682d -> 635b21c6e
>
>
> better test dependencies defaults as in wicket 7 and 8 plus changing
> wicket-core hamcrest dependency scope to test
>
>
> Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
> Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/635b21c6
> Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/635b21c6
> Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/635b21c6
>
> Branch: refs/heads/wicket-6.x
> Commit: 635b21c6e2c2862f9fc196e4af653bb209c06b36
> Parents: 5d5af68
> Author: Pedro Henrique Oliveira dos Santos 
> Authored: Mon Sep 5 19:11:31 2016 -0300
> Committer: Pedro Henrique Oliveira dos Santos 
> Committed: Mon Sep 5 19:11:31 2016 -0300
>
> --
>  pom.xml | 20 
>  wicket-core/pom.xml | 16 
>  wicket-util/pom.xml |  4 
>  3 files changed, 20 insertions(+), 20 deletions(-)
> --
>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/635b21c6/pom.xml
> --
> diff --git a/pom.xml b/pom.xml
> index c20552c..c104886 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -523,6 +523,26 @@
> test
> 
> 
> +   org.hamcrest
> +   hamcrest-library
> +   test
> +   
> +   
> +   org.hamcrest
> +   hamcrest-core
> +   test
> +   
> +   
> +   org.hamcrest
> +   hamcrest-library
> +   test
> +   
> +   
> +   org.hamcrest
> +   hamcrest-core
> +   test
> +   
>

Those new entries look duplicated to me.
If they are in  section then they don't need the 
setting. It comes from .


> +   
> org.mockito
> mockito-all
> test
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> 635b21c6/wicket-core/pom.xml
> --
> diff --git a/wicket-core/pom.xml b/wicket-core/pom.xml
> index 06c5dd2..7689a14 100644
> --- a/wicket-core/pom.xml
> +++ b/wicket-core/pom.xml
> @@ -50,22 +50,6 @@
> provided
> 
> 
> -   
> -   org.mockito
> -   mockito-all
> -   provided
> -   
> -   
> -   
> -   org.hamcrest
> -   hamcrest-library
> -   provided
> -   
> -   
> -   org.hamcrest
> -   hamcrest-core
> -   provided
> -   
> 
> 
> 
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/
> 635b21c6/wicket-util/pom.xml
> --
> diff --git a/wicket-util/pom.xml b/wicket-util/pom.xml
> index 0da1693..edd0bb9 100755
> --- a/wicket-util/pom.xml
> +++ b/wicket-util/pom.xml
> @@ -31,10 +31,6 @@
> junit
> provided
> 
> -   
> -   org.hamcrest
> -   hamcrest-library
> -   
>
>
> 
>
>