Re: Editing vendored crates take #2

At one point the steps at https://wiki.mozilla.org/Platform/GFX/Quantum_Render#Testing_third-party_rust_library_changes were known to work. I don't know if they have since been broken. On Fri, Apr 28, 2017 at 3:07 PM, Boris Zbarsky wrote: > On 4/28/17 1:05 PM, Josh Matthews

Re: Editing vendored crates take #2

On 4/28/17 1:05 PM, Josh Matthews wrote: Has anybody been able to make this work? I _think_ I made it work recently-ish, like so: 1) Modify toolkit/library/rust/Cargo.toml with the relevant [replace] bit. 2) Run "cargo vendor" and watch it fail because of something I never figured out.

Re: Editing vendored crates take #2

I just tried moving my changes into third_part/rust/rust-cssparser. I also needed to modify the Cargo.toml there to update the paths to cssparser-macros and procedural-masquerade because they are vendored as separate crates, rather than in-library dependencies. At this point I was still

Re: Ambient Light Sensor API

On Fri, Apr 28, 2017 at 7:10 PM, Eric Rescorla wrote: > Rather, the policy is > that we will move to requiring all new features to have HTTPS [0]. We should probably discuss that again at some point, since it's not meaningfully enforced and I don't think it has consensus within

Re: Editing vendored crates take #2

There is this bug which the Cargo team is planning to work on to help with these problems, but it hasn't been implemented yet that I know of. https://github.com/rust-lang/cargo/issues/2649#issuecomment-279615299 jack. On Fri, Apr 28, 2017 at 11:28 AM, Bobby Holley wrote:

Re: Editing vendored crates take #2

I definitely made this work at some point: https://hg.mozilla.org/try/rev/18dc070e0308 The main difference with what you seem to be doing is that my version points directly into third-party/rust, which I think is preferable anyway. On Fri, Apr 28, 2017 at 10:05 AM, Josh Matthews

Re: Ambient Light Sensor API

On Thu, Apr 27, 2017 at 11:02 PM, Frederik Braun wrote: > On 28.04.2017 05:56, Ehsan Akhgari wrote: > > On 04/27/2017 08:09 AM, Frederik Braun wrote: > >> On 27.04.2017 13:56, smaug wrote: > >>> On 04/25/2017 04:38 PM, Ehsan Akhgari wrote: > On 04/24/2017 06:04 PM,

Editing vendored crates take #2

Back in February there was a discussion about how hard it is to modify vendored Rust crates for Stylo. I can't actually find any solution to that problem - the general idea appears to be "add a [replace] section to a Cargo.toml and run cargo update", but I have not been able to make that work

Web Compatibility Testing Survey

I've invited you to fill in the following form: Web Platform Tests Survey To fill it in, visit: https://docs.google.com/forms/d/e/1FAIpQLScsbrVikqdnH32Qs-hV8YWgBi6kb5QRJtYG3KGqHba2eO2Dzw/viewform?c=0w=1usp=mail_form_link Hi All, The Product Integrity Automation Harnesses team would like your

Re: Ambient Light Sensor API

On 28.04.2017 05:56, Ehsan Akhgari wrote: > On 04/27/2017 08:09 AM, Frederik Braun wrote: >> On 27.04.2017 13:56, smaug wrote: >>> On 04/25/2017 04:38 PM, Ehsan Akhgari wrote: On 04/24/2017 06:04 PM, Martin Thomson wrote: > I think that 60Hz is too high a rate for this. > > I