Re: Proposal to adjust testing to run on PGO builds only and not test on OPT builds

2019-01-04 Thread jmaher
thanks everyone for your comments on this. It sounds like from a practical standpoint until we can get the runtimes of PGO builds on try and in integration to be less than debug build times this is not a desirable change. A few common responses: * artifact opt builds on try are fast for quick

Re: Proposal to adjust testing to run on PGO builds only and not test on OPT builds

2019-01-04 Thread Nathan Froyd
On Fri, Jan 4, 2019 at 11:57 AM Nicholas Alexander wrote: > One reason we might not want to stop producing opt builds: we produce > artifact builds against opt (and debug, with --enable-debug in the local > mozconfig). It'll be very odd to have --enable-artifact-build and > _require_

Re: Proposal to adjust testing to run on PGO builds only and not test on OPT builds

2019-01-04 Thread Nicholas Alexander
On Thu, Jan 3, 2019 at 1:47 PM Chris AtLee wrote: > Thank you Joel for writing up this proposal! > > Are you also proposing that we stop the linux64-opt and win64-opt builds as > well, except for leaving them as an available option on try? If we're not > testing them on integration or release

Re: Rust code coverage

2019-01-04 Thread Bobby Holley
On Fri, Jan 4, 2019 at 4:54 AM Marco Castelluccio wrote: > Hi everyone, > we have recently enabled collecting code coverage for Rust code too, > running Rust tests in coverage builds. It'll be great to finally see code coverage for the style system - thanks for doing this! > The support is

Rust code coverage

2019-01-04 Thread Marco Castelluccio
Hi everyone, we have recently enabled collecting code coverage for Rust code too, running Rust tests in coverage builds. The support is still experimental, file bugs in the "Testing::Code Coverage" component if you see something fishy. The Rust reports are merged together with the

Re: Proposal to adjust testing to run on PGO builds only and not test on OPT builds

2019-01-04 Thread Henrik Skupin
Nicholas Alexander wrote on 03.01.19 18:41: > 1) automation builds need a special configuration piece in place to > properly support artifact builds. Almost certainly that's not in place for > PGO builds, since it's such an unusual thing to do: "you want to pack PGO > binaries into a development