Re: Dominator tree memory analysis now in Nightly

2016-01-19 Thread Helen Holmes
There's actually a bug on file with designs that I'd like to implement for exposing panels better than they currently. (If you look at the mockups, not dissimilar to what Nick's suggesting!) As for whether or not we should always expose the Memory tool

Re: Dominator tree memory analysis now in Nightly

2016-01-19 Thread Helen Holmes
Apologies everyone, Jared pointed out that I didn't actually link to the bug correctly: Bug 1238982 https://bugzilla.mozilla.org/show_bug.cgi?id=1238982 On Fri, Jan 15, 2016 at 7:10 AM, Helen Holmes wrote: > There's actually a bug on file

Re: Dominator tree memory analysis now in Nightly

2016-01-19 Thread Gijs Kruitbosch
On 14/01/2016 23:01, Nick Fitzgerald wrote: On Thu, Jan 14, 2016 at 2:49 PM, Jared Wein > wrote: Also, what is the plan for making tools like the Memory view appear in a default install? In other words, without having to go to the

Re: Dominator tree memory analysis now in Nightly

2016-01-19 Thread Nick Fitzgerald
On Sat, Jan 16, 2016 at 5:41 AM, Philip Chee wrote: > This is great! Is there a way of expanding/collapsing the whole tree? > Thunderbird uses "\" (collapse) and "*" (expand). > ​You can use ALT+click on an arrow to expand a​ whole subtree. However, because after a

Re: Dominator tree memory analysis now in Nightly

2016-01-16 Thread Philip Chee
On 15/01/2016 05:50, Nick Fitzgerald wrote: > Hi folks! > > Dominator trees give you fine-grained insight into memory retention. > > In a graph rooted by some node R, a node A is said to dominate B iff > every path to B starting from R passes through A. In the context of a > heap graph, another

Re: Dominator tree memory analysis now in Nightly

2016-01-15 Thread Kyle Huey
This is awesome. We've talked about how much we've wanted this since the early days of MemShrink back in 2011. Thanks to everyone who was involved. - Kyle On Thu, Jan 14, 2016 at 1:50 PM, Nick Fitzgerald wrote: > Hi folks! > > Dominator trees give you fine-grained

Re: Dominator tree memory analysis now in Nightly

2016-01-14 Thread Robert O'Callahan
On Fri, Jan 15, 2016 at 12:01 PM, Nick Fitzgerald wrote: > Console, debugger, performance: these panels are ​a clear "always show" to > me. The web audio tool is very niche and so I don't think it would make > sense to show it by default. The memory tool falls in between

Re: Dominator tree memory analysis now in Nightly

2016-01-14 Thread Brian Grinstead
> On Jan 14, 2016, at 3:01 PM, Nick Fitzgerald wrote: > Also, what is the plan for making tools like the Memory view appear in a > default install? In other words, without having to go to the Settings. I > worry that users may not know to click on the Settings and just

Re: Dominator tree memory analysis now in Nightly

2016-01-14 Thread Nick Fitzgerald
Reply inline below. On Thu, Jan 14, 2016 at 2:49 PM, Jared Wein wrote: > From your screenshot, there are a lot of instances of "objects > Array", > "objects > Object", etc. Is the a way to display the variable name used for > those objects? > ​The node might not be in a JS

Dominator tree memory analysis now in Nightly

2016-01-14 Thread Nick Fitzgerald
Hi folks! Dominator trees give you fine-grained insight into memory retention. In a graph rooted by some node R, a node A is said to dominate B iff every path to B starting from R passes through A. In the context of a heap graph, another way to say this would be that A is retaining B: if the