Re: Linux builds now default to -O2 instead of -Os

2017-06-06 Thread jmaher
On Tuesday, June 6, 2017 at 3:17:20 PM UTC-4, Ben Kelly wrote: > On Tue, Jun 6, 2017 at 3:07 PM, Chris Peterson > wrote: > > > On 6/6/17 10:33 AM, Boris Zbarsky wrote: > > > >> On 6/1/17 9:04 PM, Mike Hommey wrote: > >> > >>> Ah, forgot to mention that. No, it doesn't

Re: Linux builds now default to -O2 instead of -Os

2017-06-06 Thread Ben Kelly
On Tue, Jun 6, 2017 at 3:07 PM, Chris Peterson wrote: > On 6/6/17 10:33 AM, Boris Zbarsky wrote: > >> On 6/1/17 9:04 PM, Mike Hommey wrote: >> >>> Ah, forgot to mention that. No, it doesn't affect *our* shipped builds >>> (because PGO uses a different set of optimization

Re: Linux builds now default to -O2 instead of -Os

2017-06-06 Thread Chris Peterson
On 6/6/17 10:33 AM, Boris Zbarsky wrote: On 6/1/17 9:04 PM, Mike Hommey wrote: Ah, forgot to mention that. No, it doesn't affect *our* shipped builds (because PGO uses a different set of optimization flags). But it does affect downstream builds that don't PGO. Based on the jump I see on June

Re: Linux builds now default to -O2 instead of -Os

2017-06-06 Thread William Lachance
On 2017-06-06 1:33 PM, Boris Zbarsky wrote: On 6/1/17 9:04 PM, Mike Hommey wrote: Ah, forgot to mention that. No, it doesn't affect *our* shipped builds (because PGO uses a different set of optimization flags). But it does affect downstream builds that don't PGO. Based on the jump I see on

Re: Linux builds now default to -O2 instead of -Os

2017-06-06 Thread Boris Zbarsky
On 6/1/17 9:04 PM, Mike Hommey wrote: Ah, forgot to mention that. No, it doesn't affect *our* shipped builds (because PGO uses a different set of optimization flags). But it does affect downstream builds that don't PGO. Based on the jump I see on June 2 at

Re: Linux builds now default to -O2 instead of -Os

2017-06-01 Thread Mike Hommey
On Fri, Jun 02, 2017 at 12:44:35AM -0400, Ehsan Akhgari wrote: > On 06/01/2017 08:51 PM, Mike Hommey wrote: > > Hi, > > > > For some reason, the default when building on Linux had stayed -Os. I > > just landed a change[1] to this default to now use -O2 instead (on > > autoland at the moment).

Re: Linux builds now default to -O2 instead of -Os

2017-06-01 Thread Ted Mielczarek
On Thu, Jun 1, 2017, at 09:23 PM, Mike Hommey wrote: > On Thu, Jun 01, 2017 at 09:09:44PM -0400, Nathan Froyd wrote: > > Could we try to make a bare --enable-optimize --enable-debug build use > > -Og if it was available? > > It might make sense, but we need to be careful that this will affect the

Re: Linux builds now default to -O2 instead of -Os

2017-06-01 Thread Mike Hommey
On Thu, Jun 01, 2017 at 09:09:44PM -0400, Nathan Froyd wrote: > On Thu, Jun 1, 2017 at 8:51 PM, Mike Hommey wrote: > > I'll take on the > > occasion to remind or inform people that recent versions of GCC (all > > versions we support, actually), and clang >= 4.0 support a -Og

Re: Linux builds now default to -O2 instead of -Os

2017-06-01 Thread Mike Hommey
On Fri, Jun 02, 2017 at 01:01:14AM +, Benjamin Smedberg wrote: > On Thu, Jun 1, 2017 at 8:52 PM Mike Hommey wrote: > > > Hi, > > > > For some reason, the default when building on Linux had stayed -Os. I > > just landed a change[1] to this default to now use -O2 instead (on

Re: Linux builds now default to -O2 instead of -Os

2017-06-01 Thread Benjamin Smedberg
On Thu, Jun 1, 2017 at 8:52 PM Mike Hommey wrote: > Hi, > > For some reason, the default when building on Linux had stayed -Os. I > just landed a change[1] to this default to now use -O2 instead (on > autoland at the moment). This is going to give better performance to > local

Linux builds now default to -O2 instead of -Os

2017-06-01 Thread Mike Hommey
Hi, For some reason, the default when building on Linux had stayed -Os. I just landed a change[1] to this default to now use -O2 instead (on autoland at the moment). This is going to give better performance to local builds (although that might make the build itself take a little longer). (Note