Re: pushPrefEnv/popPrefEnv/flushPrefEnv now return Promises

2016-05-20 Thread Mike Conley
This is great, thank you! On 19/05/2016 7:09 PM, Matthew N. wrote: > Hello, > > One of the reasons developers have been avoiding pushPrefEnv compared to > the synchronous set*Pref (with a registerCleanupFunction) is because > pushPrefEnv required using a callback function to wait for the >

Re: pushPrefEnv/popPrefEnv/flushPrefEnv now return Promises

2016-05-20 Thread Ted Mielczarek
On Thu, May 19, 2016, at 07:09 PM, Matthew N. wrote: > Hello, > > One of the reasons developers have been avoiding pushPrefEnv compared to > the synchronous set*Pref (with a registerCleanupFunction) is because > pushPrefEnv required using a callback function to wait for the > preference change

Re: pushPrefEnv/popPrefEnv/flushPrefEnv now return Promises

2016-05-19 Thread Andrew McCreight
On Thu, May 19, 2016 at 4:09 PM, Matthew N. wrote: > As a reminder, the nice thing about pushPrefEnv is that the pref changes > are reverted at the end of the test file which avoids them leaking into > other tests unintentionally. > Another good thing about it is that

pushPrefEnv/popPrefEnv/flushPrefEnv now return Promises

2016-05-19 Thread Matthew N.
Hello, One of the reasons developers have been avoiding pushPrefEnv compared to the synchronous set*Pref (with a registerCleanupFunction) is because pushPrefEnv required using a callback function to wait for the preference change before moving on in the test file. This can make the test flow