Re: Re-visiting the DOM tree depth limit in layout

2017-09-13 Thread Eric Rahm
Jan is right, increasing the stack size for all threads would cause a very large memory regression. Lets not do that ;) Selectively increasing might make sense but we'd need to keep an eye on how large of an increase we're expecting. -e On Wed, Sep 13, 2017 at 7:19 AM, Jan de Mooij

Re: 57 beta cycle: 57beta/devedition published earlier + soft freeze

2017-09-13 Thread Kim Moir
Several releng folks, RyanVM and jcristau had a meeting today discussing tomorrow's merge We wanted to ensure that we would be able to have the correct branding for Fennec beta after the merge. In order to do this, we will have a relbranch created for Fennec on Sept 14 named

Re: [Sheriffs] Intent to Implement: Remove Treeherder Exclusion Profiles in lieu of Tiers

2017-09-13 Thread Ryan VanderMeulen
How will this work with release branches like ESR52? On Wed, Sep 13, 2017 at 1:25 PM, Cameron Dawson wrote: > Just an update that Bug 1387640 is progressing and soon the “Excluded > Jobs” button in Treeherder will disappear. > > We have rolled out the changes to our staging

Re: Intent to Implement: Remove Treeherder Exclusion Profiles in lieu of Tiers

2017-09-13 Thread Cameron Dawson
Just an update that Bug 1387640 is progressing and soon the “Excluded Jobs” button in Treeherder will disappear. We have rolled out the changes to our staging environment (treeherder.allizom.org ) and will let it soak for a day or so before pushing to

PSA: nsPipe3.cpp is now using diagnostic assertions

2017-09-13 Thread Ben Kelly
Hi all, FYI, I just pushed a patch to nsPipe3.cpp that switches it to use MOZ_DIAGNOSTIC_ASSERT() instead of the weaker assertions it used to use. This class is used extensively throughout the browser and state problems can manifest as intermittent hangs, crashes, and memory leaks. For example,

Re: Re-visiting the DOM tree depth limit in layout

2017-09-13 Thread Mike Hommey
On Wed, Sep 13, 2017 at 10:03:55AM -0700, Eric Rahm wrote: > Jan is right, increasing the stack size for all threads would cause a very > large memory regression. Lets not do that ;) Selectively increasing might > make sense but we'd need to keep an eye on how large of an increase we're >

Re: Status of CSS break-* properties

2017-09-13 Thread Karl Dubost
Le 13 sept. 2017 à 21:24, Jonathan Kew a écrit : > There's a bug on file: https://bugzilla.mozilla.org/show_bug.cgi?id=775628. > But I'm not aware of any timeline for fixing this. And https://bugzilla.mozilla.org/show_bug.cgi?id=1179406 -- Karl Dubost, mozilla  Webcompat

Re: Re-visiting the DOM tree depth limit in layout

2017-09-13 Thread Henri Sivonen
On Tue, Sep 12, 2017 at 12:46 PM, Henri Sivonen wrote: > On Tue, Sep 12, 2017 at 12:35 PM, Henri Sivonen wrote: >> I'm rather unhappy about the prospect of having to examine another >> browser's HTML parser beyond reading the spec in order to achieve

Re: Status of CSS break-* properties

2017-09-13 Thread Jonathan Kew
On 13/09/2017 12:31, thomas.ja...@gmail.com wrote: Hi there! Apparently, most major browsers are currently supporting "break-column", e.g., or its "-webkit-column-"-prefixed variant (based on manual testing of https://www.quirksmode.org/css/columns/breaks.html in latest Chrome, Safari, Edge

Re: Re-visiting the DOM tree depth limit in layout

2017-09-13 Thread Ben Kelly
On Wed, Sep 13, 2017 at 4:44 AM, Henri Sivonen wrote: > I suggest we do the following: > > 1) Change the HTML parser behave more like Blink's: Raise the limit > to 513 elements deep and append elements violating the limit to the > 512th element on the stack instead of

Status of CSS break-* properties

2017-09-13 Thread thomas . jaggi
Hi there! Apparently, most major browsers are currently supporting "break-column", e.g., or its "-webkit-column-"-prefixed variant (based on manual testing of https://www.quirksmode.org/css/columns/breaks.html in latest Chrome, Safari, Edge and IE 11). However, I couldn't find any information

PSA: Making Windows 10 SDK version 10.0.10586 the minimum for building Firefox

2017-09-13 Thread bowen
Hi, I'm just about to land a patch that makes Windows 10 SDK version 10.0.10586 the minimum required for building Firefox. We require this to be able to compile certain features for the Chromium Windows process sandbox. If you are using Visual Studio 2015 and you don't have this, it (or a

Re: Re-visiting the DOM tree depth limit in layout

2017-09-13 Thread Henri Sivonen
On Sep 13, 2017 15:52, "Ben Kelly" wrote: On Wed, Sep 13, 2017 at 4:44 AM, Henri Sivonen wrote: > I suggest we do the following: > > 1) Change the HTML parser behave more like Blink's: Raise the limit > to 513 elements deep and append elements

Re: Re-visiting the DOM tree depth limit in layout

2017-09-13 Thread Jan de Mooij
On Wed, Sep 13, 2017 at 10:44 AM, Henri Sivonen wrote: > 3) Increase the run-time stack size on Windows such that 1026-deep > display: table-cell doesn't overflow the stack. > On Windows, threads that are created without an explicit stack size also use the executable's

Re: Intent to unship: Visibility of window.content to untrusted code

2017-09-13 Thread Mike Taylor
On 9/12/17 5:04 PM, Boris Zbarsky wrote: > We could also delay the removal to after 57 to mitigate 57 risk Or remove it for non-RELEASE_OR_BETA builds for a release or two to see what shakes out in Nightly/DevEdition reports. -- Mike Taylor Web Compat, Mozilla