Re: -Werror vs. NetBSD

2016-01-31 Thread Martin Thomson
Hi Thomas, Do you think that you could push these patches to bugzilla? See https://bugzilla.mozilla.org/enter_bug.cgi?product=NSS=Libraries And it would be easier to review this as a single patch, I think, since all the changes are fairly simple. On Sat, Jan 30, 2016 at 11:40 PM, Thomas

-Werror vs. NetBSD

2016-01-31 Thread Thomas Klausner
Hi! Recently nss turned on -Werror by default for all platforms. I think that's a good idea. However, it majorly broke the build on NetBSD with lots of these types of messages: certcgi.c: In function 'MakeNameConstraints': certcgi.c:1654:6: error: array subscript has type 'char'