I understand the urge to have consistent formatting, and that ideas
about the best way to format evolve over time.
Here's the A#1 reason this is NOT necessarily a good idea: It obscures
the real changes when you compare versions.
If you want to change formatting standards, knock yourselves
Patches converting most of js/src have landed and the style guide has been
updated. I'll post patches for the few remaining directories and XPConnect
this week.
Don't worry too much about fixing up in-flight patches; I'll run the script
again in a few days.
Thanks,
Jan
On Wed, Sep 5, 2018 at
On 09/05/2018 02:29 AM, Benjamin Bouvier wrote:
> I don't buy Jeff's argument at all; in the case of the (in)famous Apple SSL
> bug, there *was* proper indentation and missing braces on the if, and
> though this wasn't enough to catch the failure.
*Having* the rule is not the same as *enforcing*
On Tue, Sep 4, 2018 at 12:49 PM Bobby Holley wrote:
> +1
>
> The one downside of doing this now is that we'll eventually do another bulk
> reformat of all of mozilla-central once we settle on a clang-format
> version+config whose output we're happy with. So if that were to happen
> very soon
I don't buy Jeff's argument at all; in the case of the (in)famous Apple SSL
bug, there *was* proper indentation and missing braces on the if, and
though this wasn't enough to catch the failure. Meta bug 1297639 has
dependents that show real-world issues because of missing braces, including
in
On 09/04/2018 10:59 AM, David Teller wrote:
> Point taken. Not going to fight over this :)
:-) ^ 2
Jeff
___
dev-tech-js-engine-internals mailing list
dev-tech-js-engine-internals@lists.mozilla.org
On 09/04/2018 07:50 AM, David Teller wrote:
> I am all for making braces a requirement, both to unify with Gecko and
> for safety reasons – it would be really annoying to introduce bugs, as
> Apple did not that long ago, just because of missing braces.
I say this all with a bit of a smile (in
+1 for consistency
I was wondering about the timing of any big clang-format changes too; makes
sense to do this sooner than later if the clang-format changes aren't
imminent.
On Tue, Sep 4, 2018 at 11:48 AM, Bobby Holley wrote:
> +1
>
> The one downside of doing this now is that we'll
+1
The one downside of doing this now is that we'll eventually do another bulk
reformat of all of mozilla-central once we settle on a clang-format
version+config whose output we're happy with. So if that were to happen
very soon (unlikely), doing piecemeal handling of braces now would result
in
I'm a "yes" on this as well. I really don't care much either way in terms
of personal preference, but the consistency argument works for me as it
does for sfink.
Kannan
On Tue, Sep 4, 2018 at 12:04 PM Steve Fink wrote:
> Heh. I find the bug argument unconvincing. It's true that the
>
Heh. I find the bug argument unconvincing. It's true that the
always-brace style is slightly less error-prone, but since this is only
used for very short clauses it seems like a very minor win in practice,
and much less significant to my eye than the benefits in evening out the
code density. I
11 matches
Mail list logo
