Github user janmaterne commented on the issue:
https://github.com/apache/ant/pull/31
Haven't done a deep check, but first comments:
- overall it seems to be ok
- get.html: maybe a hint that key and value are trimmed and must not be
null or empty string
- get.html, example:
Github user arcadius commented on a diff in the pull request:
https://github.com/apache/ant/pull/31#discussion_r98555008
--- Diff: src/main/org/apache/tools/ant/taskdefs/Get.java ---
@@ -726,6 +761,14 @@ private URLConnection openConnection(final URL
aSource) throws IOException {
Github user arcadius commented on a diff in the pull request:
https://github.com/apache/ant/pull/31#discussion_r98559239
--- Diff: src/etc/testcases/taskdefs/get.xml ---
@@ -98,6 +98,34 @@
+
+http://www.apache.org/; dest="get.tmp">
+
Github user arcadius commented on a diff in the pull request:
https://github.com/apache/ant/pull/31#discussion_r98552982
--- Diff: manual/Tasks/get.html ---
@@ -170,6 +170,29 @@
name will be skipped. If the returned name is a relative path, it
will be considered
Github user arcadius commented on a diff in the pull request:
https://github.com/apache/ant/pull/31#discussion_r98553907
--- Diff: manual/Tasks/get.html ---
@@ -234,6 +257,17 @@
url url=http://ant.apache.org/faq.html/;
/get
+
+With custom HTTP headers
Github user arcadius commented on a diff in the pull request:
https://github.com/apache/ant/pull/31#discussion_r98557699
--- Diff: src/main/org/apache/tools/ant/taskdefs/Get.java ---
@@ -483,6 +489,35 @@ public void setTryGzipEncoding(boolean b) {
}
/**
Github user arcadius commented on the issue:
https://github.com/apache/ant/pull/31
Thank you very much @janmaterne for taking the time to review the code.
Most appreciated. :+1:
I have made all suggested changes.
Feel free to have a look.
Many thanks.
I am trying to figure out how updatesite resolver works, but the
documentation is somewhat lacking...
For instance, http://ant.apache.org/ivy/history/trunk/osgi/osgi-mapping.html
suggests using osgi attribute, which seems more logical than org="bundle"
or org="package" (especially when
