Re: delete task with a wildcard "file"

2017-12-20 Thread Stefan Bodewig
On 2017-12-21, Jaikiran Pai wrote: > Is it expected that the delete task with a file="*.py"(like below) > will consider the * a wildcard and delete all files with a .py > extension? No, not at all. > My understanding based on the docs is that it should actually be the > exact file name (either

[GitHub] ant issue #52: [master] Fix BZ-58451 BZ-58833

2017-12-20 Thread jaikiran
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/52 @bodewig, do you think this change is OK? Any thoughts/concerns? I understand that this is one of the central classes, so don't want to push this if there's any concerns with this change. ---

delete task with a wildcard "file"

2017-12-20 Thread Jaikiran Pai
Is it expected that the delete task with a file="*.py"(like below) will consider the * a wildcard and delete all files with a .py extension? My understanding based on the docs is that it should actually be the exact file name (either relative or absolute) and for something like wildcard

Re: delete task with a wildcard "file"

2017-12-20 Thread Jaikiran Pai
On 21/12/17 10:42 AM, Stefan Bodewig wrote: On 2017-12-21, Jaikiran Pai wrote: I committed this change below, to use a resource collection to allow the build to pass, which had started failing on Windows, after I did a recent change to the delete task to use Java 7 java.nio.file.Files API.

[GitHub] ant pull request #:

2017-12-20 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/242d661161ddf2b28e6df23847c1471ee788bab7#commitcomment-26396824 In src/main/org/apache/tools/ant/util/SymbolicLinkUtils.java: In src/main/org/apache/tools/ant/util/SymbolicLinkUtils.java on line

Re: [GitHub] ant pull request #:

2017-12-20 Thread Jaikiran Pai
No specific reason, just that I'm more used to using the javadoc variant of @deprecated since it allows explaining what's deprecated and why. I have now added the @Deprecated annotation too and pushed a commit. -Jaikiran On 20/12/17 11:08 PM, twogee wrote: Github user twogee commented on