Github user arcadius commented on the issue:
https://github.com/apache/ant/pull/31
Hello @janmaterne ... is there anything i can do to help get this through?
Thank you very much.
Arcadius.
---
If your project is set up for it, you can reply to this email
GitHub user arcadius opened a pull request:
https://github.com/apache/ant/pull/31
Feature/bugzilla bug 60628 ant get task to accept arbitrary header
[AA] bugzilla Bug 60628 Ant-Get-Task-To-Accept-Arbitrary-Header
You can merge this pull request into a Git repository by running
Github user arcadius commented on the issue:
https://github.com/apache/ant/pull/31
@mbenson , would you be able to review this pull request for me?
It is very similar to the email header that you worked on.
---
If your project is set up for it, you can reply to this email
Github user arcadius commented on a diff in the pull request:
https://github.com/apache/ant/pull/31#discussion_r98555008
--- Diff: src/main/org/apache/tools/ant/taskdefs/Get.java ---
@@ -726,6 +761,14 @@ private URLConnection openConnection(final URL
aSource) throws IOException
Github user arcadius commented on a diff in the pull request:
https://github.com/apache/ant/pull/31#discussion_r98559239
--- Diff: src/etc/testcases/taskdefs/get.xml ---
@@ -98,6 +98,34 @@
+
+http://www.apache.org/; dest="ge
Github user arcadius commented on a diff in the pull request:
https://github.com/apache/ant/pull/31#discussion_r98552982
--- Diff: manual/Tasks/get.html ---
@@ -170,6 +170,29 @@
name will be skipped. If the returned name is a relative path, it
will be considered
Github user arcadius commented on a diff in the pull request:
https://github.com/apache/ant/pull/31#discussion_r98553907
--- Diff: manual/Tasks/get.html ---
@@ -234,6 +257,17 @@
url url=http://ant.apache.org/faq.html/;
/get
+
+With custom HTTP headers
Github user arcadius commented on a diff in the pull request:
https://github.com/apache/ant/pull/31#discussion_r98557699
--- Diff: src/main/org/apache/tools/ant/taskdefs/Get.java ---
@@ -483,6 +489,35 @@ public void setTryGzipEncoding(boolean b
Github user arcadius commented on the issue:
https://github.com/apache/ant/pull/31
Thank you very much @janmaterne for taking the time to review the code.
Most appreciated. :+1:
I have made all suggested changes.
Feel free to have a look.
Many thanks
Github user arcadius commented on the issue:
https://github.com/apache/ant/pull/31
Thank you very much @janmaterne for your help
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
10 matches
Mail list logo
