Github user janmaterne commented on the issue:
https://github.com/apache/ant/pull/31
Haven't done a deep check, but first comments:
- overall it seems to be ok
- get.html: maybe a hint that key and value are trimmed and must not be
null or empty string
- get.html, example
Github user janmaterne commented on the issue:
https://github.com/apache/ant/pull/31
committed to master branch (Ant 1.10.x).
thanks for the patch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/15
close test-PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user janmaterne closed the pull request at:
https://github.com/apache/ant-ivy/pull/15
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user janmaterne opened a pull request:
https://github.com/apache/ant-ivy/pull/14
Create just-test-github-integration
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/janmaterne/ant-ivy patch-1
Alternatively you can review
GitHub user janmaterne opened a pull request:
https://github.com/apache/ant-ivy/pull/15
Create just-test-github-integration
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/janmaterne/ant-ivy patch-2
Alternatively you can review
Github user janmaterne closed the pull request at:
https://github.com/apache/ant-ivy/pull/14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user janmaterne opened a pull request:
https://github.com/apache/ant-ivy/pull/28
DontMerge-testing-Github-integration
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/janmaterne/ant-ivy patch-3
Alternatively you can
Github user janmaterne closed the pull request at:
https://github.com/apache/ant-ivy/pull/28
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user janmaterne closed the pull request at:
https://github.com/apache/ant-ivy/pull/29
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/29
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user janmaterne closed the pull request at:
https://github.com/apache/ant-ivy/pull/29
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user janmaterne reopened a pull request:
https://github.com/apache/ant-ivy/pull/29
DontMerge-testing-Github-integration2
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/janmaterne/ant-ivy patch-4
Alternatively you can
GitHub user janmaterne opened a pull request:
https://github.com/apache/ant-ivy/pull/29
DontMerge-testing-Github-integration2
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/janmaterne/ant-ivy patch-4
Alternatively you can
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/33
You're right. I looked at a dictionary. I'll change that, so haven't to
think about that in the future. ;)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/34
- we dont use @author
- TestXmlHelper
-- if xPathExpression would be a String and the method compiles that for
itself,
reuse would be easier
-- XmlHelper would be a better
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/35
merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/31
Nice idea to use the old fail-Message as new method comment to document why
the exception is expected.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/31
merged, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user janmaterne opened a pull request:
https://github.com/apache/ant-ivyde/pull/5
DontMerge-Test-Github-Integration
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/janmaterne/ant-ivyde patch-1
Alternatively you can
Github user janmaterne closed the pull request at:
https://github.com/apache/ant-ivyde/pull/5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivyde/pull/5
Jenkins/Github-Integrationtest finished
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivyde/pull/4
merged that to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/33
Because of the problems I dont merge this ATM. We should discuss them on
the dev list before.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/33
build.xml
- Nice idea with the copyright statement in Javadoc ( (c)${years} ;
years=tstamp("2007-") ).
You found a lot of spell errors ;)
MatcherLookup.ja
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/33
start reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/33
merged, thanks for the huge work.
What about the "iff"? I am not a native speaker and dont want to judge ;)
---
If your project is set up for it, you can reply to this email and
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/34
Thanks. It was the most common error: the user error :)
Used the GUI "git history" not on the top folder ...
---
If your project is set up for it, you can reply to this email and
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/36
The JaCoCo 'logfile' seems to be a binary one. So it should not be named
'*.log'. Maybe 'jacoco-log.bin'?
In 'test-report' the should be the last statement, so we get the
report created
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/36
While not having the result of the clean-run, what about deleting the
jacoco.data file just before running ?
With ASM I could spend a little bit to do a check before ... (something
like
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/36
First progress: found an old ASM on Ant's own classpath. Ant 1.9.6 loads
that via fetch.xml. Different topic ...
JaCoCo runs fine. Report generation failed without any hint. Try running
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/36
Adressed the deletion by myself.
Left the ASM over for another time.
Merge all ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/36
Stacktrace is:
C:\projekte\apache-ant\ivy-core\build.xml:492: Error while creating report
at org.jacoco.ant.ReportTask.execute(ReportTask.java:501)
Caused
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/41
There a bunch of new image files (svg, ...) I dont think that this is
related to 'checkstyle'.
The other files:
- remove trailing spaces
- add required 'final' to parameters
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/39
Ok, license debate finished. I think its ok.
Merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/41
I found a comment in hibgraph.svg: "Helvetica is a registered trademark of
Linotype AG".
I am not sure about using that in an Apache project ...
I'll forward this to the dev ll
Github user janmaterne commented on the issue:
https://github.com/apache/ant/pull/34
Thanks for the PR. The first view:
* there isnt any test (not sure it would be possible)
* baseline is Ant_1.8, which is not maintained any more.
Current Ant is 1.9 for Java5 and Ant 1.10
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/43
Java7 supports the diamond operator and Ivy's baseline is now Java7. So you
could use that (e.g. CCFilter.java).
HMFilter: one advantage of foreach is having a meaningful iterator name
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/38
All fine with me. Maybe we could extract the method into FileUtil later.
I'll merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/44
merged, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/38
requireCommonBaseDir:
- could we replace firstPath by base==null?
- line 115: additional comment:
'fail fast: ...'
- line 117: 'finally we got ...'
getBaseDir
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/43
I wont split this PR. Adress these in this PR:
- diamond operator
- renaming
- ModuleIdTest
The other things should be done in a new PR (PRs shouldnt be too big ;)
I
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/43
Nop ... yes. You're right with 'null instanceof SomeClass'==true.
But the two assertions are different:
moduleId = null;
assertFalse(moduleId.equals(null);; --> this will th
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/43
Merged that, thanks.
Hint for future PRs: smaller are better (easier to review)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/31
That was a lot of work (or writing/using a transformator ;)
Basically it
- removes the "extends TestCase" and
- uses JUnit annotations
- change string.ind
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/55
ivy-lierre.svg:
- looks good
- havent compared, I think asciidoc/images and doc/images are the same?
- why this name? why not simply logo.svg? (ok, I see: ivy-lierre.png
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/55
Violations of the license header:
* ivy-lierre.svg (missing, remove the generator comment)
* IvyLogo (missing
Github user janmaterne commented on the issue:
https://github.com/apache/ant/pull/36
ant-unit-1.3 is in the repo
(https://github.com/apache/ant/blob/master/lib/optional/ant-antunit-1.3.jar).
It seems that you use an Ant version for building this which does not
contain this jar
Github user janmaterne commented on the pull request:
https://github.com/apache/ant/commit/ca98cc50364f694e1642f84a0c43d0134098ed30#commitcomment-29497107
In manual/credits.html:
In manual/credits.html on line 49:
acute for Antoine and grave for me. ;)
Never learnd french
Github user janmaterne commented on the issue:
https://github.com/apache/ant-ivy/pull/55
Still open are:
IvyLogo.java
JavaDoc of the parameters of IvyLogo(int width, int height) are bad
("ditto")
test the report
But a simple ivy:re
Github user janmaterne commented on the issue:
https://github.com/apache/ant/pull/62
These changes might improve performance, but do you have a testsuite with
validates that? Most of the changes are done on places which are rarely invoked
in a build (without having tested
51 matches
Mail list logo
