[GitHub] ant issue #31: Feature/bugzilla bug 60628 ant get task to accept arbitrary h...
Github user arcadius commented on the issue: https://github.com/apache/ant/pull/31 Thank you very much @janmaterne for your help --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #31: Feature/bugzilla bug 60628 ant get task to accept arbitrary h...
Github user janmaterne commented on the issue: https://github.com/apache/ant/pull/31 committed to master branch (Ant 1.10.x). thanks for the patch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #31: Feature/bugzilla bug 60628 ant get task to accept arbitrary h...
Github user arcadius commented on the issue: https://github.com/apache/ant/pull/31 Hello @janmaterne ... is there anything i can do to help get this through? Thank you very much. Arcadius. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #31: Feature/bugzilla bug 60628 ant get task to accept arbitrary h...
Github user arcadius commented on the issue: https://github.com/apache/ant/pull/31 Thank you very much @janmaterne for taking the time to review the code. Most appreciated. :+1: I have made all suggested changes. Feel free to have a look. Many thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #31: Feature/bugzilla bug 60628 ant get task to accept arbitrary h...
Github user janmaterne commented on the issue: https://github.com/apache/ant/pull/31 Haven't done a deep check, but first comments: - overall it seems to be ok - get.html: maybe a hint that key and value are trimmed and must not be null or empty string - get.html, example: value has doubled equals sign - get.xml/GetTest.java: method name doesn't match target name - Get.java: nice to reuse email.Header - Get.java: trimToNull() could be moved to org.apache.tools.ant.util.StringUtils - Get.java:764: the if(isEmpty) is not required @mbenson: Are you reviewing this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant issue #31: Feature/bugzilla bug 60628 ant get task to accept arbitrary h...
Github user arcadius commented on the issue: https://github.com/apache/ant/pull/31 @mbenson , would you be able to review this pull request for me? It is very similar to the email header that you worked on. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
